[JEWEL-876] Improving string resources for standalone

- Implemented 'AbstractDynamicBundleTest', which is a simplified version of the IDE message loader
- Updated 'IntUiMessageResourceResolver' to use the new bundle string loader

Author: faogustavo

platform/jewel/int-ui/int-ui-standalone-tests/BUILD.bazel

@@ -1,6 +1,6 @@
 ### auto-generated section `build intellij.platform.jewel.intUi.standalone.tests` start
 load("//build:compiler-options.bzl", "create_kotlinc_options")
-load("@rules_jvm//:jvm.bzl", "jvm_library")
+load("@rules_jvm//:jvm.bzl", "jvm_library", "resourcegroup")
 
 create_kotlinc_options(
   name = "custom_jewel-intUi-standalone-tests",
@@ -14,6 +14,23 @@ create_kotlinc_options(
   x_explicit_api_mode = "strict"
 )
 
+resourcegroup(
+  name = "jewel-intUi-standalone-tests_resources",
+  srcs = glob(["src/test/resources/**/*"]),
+  strip_prefix = "src/test/resources"
+)
+
+jvm_library(
+  name = "jewel-intUi-standalone-tests",
+  visibility = ["//visibility:public"],
+  srcs = glob([], allow_empty = True),
+  resources = [":jewel-intUi-standalone-tests_resources"],
+  runtime_deps = [
+    "@lib//:kotlin-stdlib",
+    "//platform/jewel/int-ui/int-ui-standalone:jewel-intUi-standalone",
+  ]
+)
+
 jvm_library(
   name = "jewel-intUi-standalone-tests_test_lib",
   module_name = "intellij.platform.jewel.intUi.standalone.tests",
@@ -25,7 +42,8 @@ jvm_library(
     "@lib//:kotlin-test",
     "@lib//:junit5",
     "//platform/jewel/int-ui/int-ui-standalone:jewel-intUi-standalone",
-  ]
+  ],
+  runtime_deps = [":jewel-intUi-standalone-tests"]
 )
 ### auto-generated section `build intellij.platform.jewel.intUi.standalone.tests` end
 

platform/jewel/int-ui/int-ui-standalone-tests/build.gradle.kts

@@ -1,6 +1,7 @@
 plugins { jewel }
 
 dependencies {
+    api(projects.intUi.intUiStandalone)
     testImplementation(kotlin("test"))
     testImplementation(libs.junit.jupiter)
     testRuntimeOnly(libs.junit.platform.engine)

platform/jewel/int-ui/int-ui-standalone-tests/intellij.platform.jewel.intUi.standalone.tests.iml

@@ -20,6 +20,7 @@
     <exclude-output />
     <content url="file://$MODULE_DIR$">
       <sourceFolder url="file://$MODULE_DIR$/src/test/kotlin" isTestSource="true" />
+      <sourceFolder url="file://$MODULE_DIR$/src/test/resources" type="java-resource" />
     </content>
     <orderEntry type="inheritedJdk" />
     <orderEntry type="sourceFolder" forTests="false" />

platform/jewel/int-ui/int-ui-standalone-tests/src/test/kotlin/org/jetbrains/jewel/intui/core/theme/DynamicBundleTest.kt

@@ -0,0 +1,77 @@
+// Copyright 2000-2025 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
+package org.jetbrains.jewel.intui.core.theme
+
+import java.util.concurrent.Executors
+import kotlin.test.assertEquals
+import kotlin.test.assertTrue
+import org.jetbrains.jewel.intui.standalone.bundle.DynamicBundle
+import org.junit.jupiter.api.Test
+
+private val MNEMONIC = 0x1B.toChar().toString()
+
+internal class DynamicBundleTest {
+    private val testBundle = DynamicBundle(DynamicBundle::class.java, "messages.TestBundle")
+
+    @Test
+    fun loads_plain_message() {
+        val msg = testBundle.getMessage("plain.hello")
+        assertEquals("Hello", msg)
+    }
+
+    @Test
+    fun formats_parameterized_message() {
+        val msg = testBundle.getMessage("hello.param", "World")
+        assertEquals("Hello World", msg)
+    }
+
+    @Test
+    fun mnemonic_single_ampersand() {
+        val msg = testBundle.getMessage("menu.open")
+        // Current implementation inserts the mnemonic marker for single '&' on all OSes
+        assertEquals(MNEMONIC + "Open", msg)
+    }
+
+    @Test
+    fun mnemonic_double_ampersand_differs_by_os() {
+        val msg = testBundle.getMessage("menu.copy")
+        // Accept both outcomes depending on the underlying OS
+        val macExpectation = "Copy $MNEMONIC Paste"
+        val nonMacExpectation = "Copy  Paste"
+        assertTrue(msg == macExpectation || msg == nonMacExpectation, "Unexpected processed value: '$msg'")
+    }
+
+    @Test
+    fun escapedAmpersand_doesNotAddMnemonic() {
+        val msg = testBundle.getMessage("menu.copy.paste")
+        assertEquals("Copy & Paste", msg)
+    }
+
+    @Test
+    fun concurrent_message_access_does_not_fail() {
+        val pool = Executors.newFixedThreadPool(4)
+        try {
+            val tasks = (1..12).map { pool.submit<String> { testBundle.getMessage("plain.hello") } }
+            tasks.forEach { assertEquals("Hello", it.get()) }
+        } finally {
+            pool.shutdownNow()
+        }
+    }
+
+    @Test
+    fun english_ordinal_formatting_via_reflection() {
+        assertEquals("Value: 1st", testBundle.getMessage("number.ordinal", 1))
+        assertEquals("Value: 2nd", testBundle.getMessage("number.ordinal", 2))
+        assertEquals("Value: 3rd", testBundle.getMessage("number.ordinal", 3))
+        assertEquals("Value: 4th", testBundle.getMessage("number.ordinal", 4))
+        assertEquals("Value: 11th", testBundle.getMessage("number.ordinal", 11))
+        assertEquals("Value: 12th", testBundle.getMessage("number.ordinal", 12))
+        assertEquals("Value: 13th", testBundle.getMessage("number.ordinal", 13))
+        assertEquals("Value: 14th", testBundle.getMessage("number.ordinal", 14))
+        assertEquals("Value: 21st", testBundle.getMessage("number.ordinal", 21))
+        assertEquals("Value: 22nd", testBundle.getMessage("number.ordinal", 22))
+        assertEquals("Value: 23rd", testBundle.getMessage("number.ordinal", 23))
+        assertEquals("Value: 24th", testBundle.getMessage("number.ordinal", 24))
+        assertEquals("Value: 101st", testBundle.getMessage("number.ordinal", 101))
+        assertEquals("Value: 404th", testBundle.getMessage("number.ordinal", 404))
+    }
+}

platform/jewel/int-ui/int-ui-standalone-tests/src/test/resources/messages/TestBundle.properties

@@ -0,0 +1,7 @@
+# Copyright 2000-2025 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
+plain.hello=Hello
+hello.param=Hello {0}
+menu.open=&Open
+menu.copy=Copy && Paste
+menu.copy.paste=Copy \\& Paste
+number.ordinal=Value: {0,number,ordinal}

platform/jewel/int-ui/int-ui-standalone/api-dump-experimental.txt

@@ -1,3 +1,12 @@
+*f:org.jetbrains.jewel.intui.standalone.JewelIntUIBundle
+- org.jetbrains.jewel.intui.standalone.bundle.AbstractDynamicBundle
+- sf:$stable:I
+- sf:INSTANCE:org.jetbrains.jewel.intui.standalone.JewelIntUIBundle
+*a:org.jetbrains.jewel.intui.standalone.bundle.AbstractDynamicBundle
+- sf:$stable:I
+- <init>(java.lang.Class,java.lang.String):V
+- f:getLazyMessage(java.lang.String,java.lang.Object[]):java.util.function.Supplier
+- f:getMessage(java.lang.String,java.lang.Object[]):java.lang.String
 f:org.jetbrains.jewel.intui.standalone.styling.IntUiIconButtonStylingKt
 - *sf:darkTransparentBackground(org.jetbrains.jewel.ui.component.styling.IconButtonStyle$Companion,org.jetbrains.jewel.ui.component.styling.IconButtonColors,org.jetbrains.jewel.ui.component.styling.IconButtonMetrics):org.jetbrains.jewel.ui.component.styling.IconButtonStyle
 - *bs:darkTransparentBackground$default(org.jetbrains.jewel.ui.component.styling.IconButtonStyle$Companion,org.jetbrains.jewel.ui.component.styling.IconButtonColors,org.jetbrains.jewel.ui.component.styling.IconButtonMetrics,I,java.lang.Object):org.jetbrains.jewel.ui.component.styling.IconButtonStyle

platform/jewel/int-ui/int-ui-standalone/src/main/kotlin/org/jetbrains/jewel/intui/standalone/IntUiMessageResourceResolver.kt

@@ -10,7 +10,7 @@ import org.jetbrains.jewel.ui.util.MessageResourceResolver
  * associated with specific keys. It can be used to retrieve action text for UI elements, like buttons or menu items
  * based on the string keys from IntelliJ Platform resource bundle.
  */
-internal class IntUiMessageResourceResolver : MessageResourceResolver {
+internal object IntUiMessageResourceResolver : MessageResourceResolver {
     /**
      * Fetches the string associated with a given key.
      *
@@ -21,11 +21,5 @@ internal class IntUiMessageResourceResolver : MessageResourceResolver {
      *   message bundle (e.g, ""action.text.copy.link.address").
      * @return The string associated with the provided key. If the key is not found, an empty string is returned.
      */
-    override fun resolveIdeBundleMessage(key: String): String =
-        when (key) {
-            "action.text.open.link.in.browser" -> "Open Link in Browser"
-            "action.text.copy.link.address" -> "Copy Link Address"
-            "action.text.more" -> "More"
-            else -> ""
-        }
+    override fun resolveIdeBundleMessage(key: String): String = JewelIntUIBundle.getMessage(key)
 }

platform/jewel/int-ui/int-ui-standalone/src/main/kotlin/org/jetbrains/jewel/intui/standalone/JewelIntUIBundle.kt

@@ -0,0 +1,15 @@
+// Copyright 2000-2025 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
+package org.jetbrains.jewel.intui.standalone
+
+import org.jetbrains.annotations.ApiStatus
+import org.jetbrains.jewel.foundation.ExperimentalJewelApi
+import org.jetbrains.jewel.intui.standalone.bundle.DynamicBundle
+
+/**
+ * Loads the JewelBundle messages with required messages by Jewel.
+ *
+ * The counterpart of this in the LaF is the [com.intellij.ide.IdeBundle], which provides the necessary strings.
+ */
+@ApiStatus.Experimental
+@ExperimentalJewelApi
+public object JewelIntUIBundle : DynamicBundle(JewelIntUIBundle::class.java, "messages.JewelBundle")