Skip to content

Update default value of min_tick_distance in potential calculation #448

@fhagemann

Description

@fhagemann

min_tick_distance::NTuple{3, T} = if CS == Cylindrical
if !ismissing(min_tick_distance)
if min_tick_distance isa LengthQuantity
world_r_mid = (sim.world.intervals[1].right + sim.world.intervals[1].left)/2
min_distance_z = min_distance_r = T(to_internal_units(min_tick_distance))
min_distance_r, min_distance_z / world_r_mid, min_distance_z
else
T(to_internal_units(min_tick_distance[1])),
T(to_internal_units(min_tick_distance[2])),
T(to_internal_units(min_tick_distance[3]))
end
else
(T(1e-5), T(1e-5) / (0.25 * grid.axes[1][end]), T(1e-5))
end
else
if !ismissing(min_tick_distance)
if min_tick_distance isa LengthQuantity
min_distance = T(to_internal_units(min_tick_distance))
min_distance, min_distance, min_distance
else
T(to_internal_units(min_tick_distance[1])),
T(to_internal_units(min_tick_distance[2])),
T(to_internal_units(min_tick_distance[3]))
end
else
(T(1e-5), T(1e-5), T(1e-5))
end
end

Right now, we set the default value for min_tick_distance to 1e-5, which are 10µm. Any structures finer than 10µm will not be well resolved in simulations using the default values. We should think about adjusting this value (and maybe max_tick_ratio) to something less hard-coded such that the default values describe any simulation (and not just "large scale" simulations) best.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions