-
Notifications
You must be signed in to change notification settings - Fork 49
Open
Labels
breakingChanges syntax to older versionsChanges syntax to older versionsdependenciesPull requests that update a dependency filePull requests that update a dependency filedocumentationThis issue asks for documentationThis issue asks for documentationhelp wantedExtra attention is neededExtra attention is needednew featureAdd new featureAdd new feature
Milestone
Description
Some things that would still need to be done:
- Draft release note with breaking changes --> look at what we had to change in Change AbstractCoordinatePoint to not be a FieldVector #489 (tests and code-wise) and what behavior is not supported anymore. Think about whether we want to have functions that throw verbose warnings (for example when the user tries to add two
CartesianPointsor converting anAbstractVectorto aCartesianPoint) - Operations with CartesianPoints not supported and causing errors #552: make sure all current code works with the new implementation of
CartesianPoint - Check that all documentation is updated or add documentation about the new things where missing
- Add tests for cases that might be needed or for weird things we discovered
Possible other breaking changes to incorporate in this release:
- Noted in Fix
offsetfor linear and cylindrical impurity densities #544: forLinearImpurityDensityandCylindricalImpurityDensity, changeoffsetsfrom being anNTupleto being just a numberTat the origin of the coordinate system. - The user should be able to choose the "unit" of waveforms. #284: allow the user to choose whether the output should be given in units of charge or units of energy.
- Update default value of
min_tick_distancein potential calculation #448: choose a bettermin_tick_distance, e.g. based on the dimensions of the world (might also be relevant for the dead-layer simulations) - Fully support
CartesianPointswith units #183: units in general (?)
Feature request:
- Right now, the Lithium drifted contact can only be one of them (just one contact id), should we also allow for multiple contact IDs, as for example for the p-type segBEGe detector, that has 4 segments, each of which are Lithium drifted.
Thinking about breaking changes:
- If there are any other breaking changes, now is the time to merge them:
Metadata
Metadata
Assignees
Labels
breakingChanges syntax to older versionsChanges syntax to older versionsdependenciesPull requests that update a dependency filePull requests that update a dependency filedocumentationThis issue asks for documentationThis issue asks for documentationhelp wantedExtra attention is neededExtra attention is needednew featureAdd new featureAdd new feature