Roles are updated even when there are no changes to make when synchronizing Kenna users with AD users #448
Description
The update_user function in user_role_sync.rb is responsible for updating users and is called when synchronizing Kenna users/roles with AD users/groups.
Due to a broken conditional and misplaced code, this function will update users even if they've never changed, which leads to every user in the system being updated every time the code runs.
The following changes are required:
- Compare new and existing roles for users using sets rather than arrays (i.e. so order doesn't matter)
- These lines needs to be moved into the above conditional after it's fixed (i.e. the highlighted code needs to go into an "if statement")
Example output:
...
"[+] (20221214172423) Email:[email protected] , First:Tom , Last:Nook , Role:[\"Landlords\", \"Small Business Owners\"]",
"[!] (20221214172423) Role Already Exists.",
"[!] (20221214172423) Role Already Exists.",
"[!] (20221214172423) User Already Exists. Updating User.",
"[+] (20221214172423) ROLE CHANGE: User [email protected] - [\"Small Business Owners\", \"Landlords\"] => [\"Landlords\", \"Small Business Owners\"].",
...