From a21ef53d2fd41dccf5fd8fe564777c2e68a73774 Mon Sep 17 00:00:00 2001 From: Brian Hill Date: Wed, 4 Mar 2026 12:56:09 -0500 Subject: [PATCH 1/2] fixed sans issue passed to extension data --- .gitignore | 1 + GCPCAS/Client/CreateCertificateRequestBuilder.cs | 14 ++++++++------ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.gitignore b/.gitignore index 8932a7e..6be482b 100644 --- a/.gitignore +++ b/.gitignore @@ -352,3 +352,4 @@ healthchecksdb logs *.pem *.crt +.claude/settings.local.json diff --git a/GCPCAS/Client/CreateCertificateRequestBuilder.cs b/GCPCAS/Client/CreateCertificateRequestBuilder.cs index 86b42b8..22f587f 100644 --- a/GCPCAS/Client/CreateCertificateRequestBuilder.cs +++ b/GCPCAS/Client/CreateCertificateRequestBuilder.cs @@ -1,5 +1,5 @@ /* -Copyright © 2025 Keyfactor +Copyright � 2025 Keyfactor Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. @@ -85,12 +85,14 @@ public ICreateCertificateRequestBuilder WithEnrollmentProductInfo(EnrollmentProd string base64Value = param.Value; _logger.LogTrace($"Loggin oid and value {oid} {base64Value}"); - - var extension = CreateX509Extension(oid, base64Value); - if (extension != null) + if (oid != "2.5.29.17") //can't send Sans as an extension to google, they do not like this and you will get an error { - _logger.LogTrace($"Adding Extension"); - _additionalExtensions.Add(extension); + var extension = CreateX509Extension(oid, base64Value); + if (extension != null) + { + _logger.LogTrace($"Adding Extension"); + _additionalExtensions.Add(extension); + } } } } From b61e5e57f55b8d47018790f75b71775f743f9807 Mon Sep 17 00:00:00 2001 From: Brian Hill Date: Wed, 4 Mar 2026 13:18:20 -0500 Subject: [PATCH 2/2] fixed change log --- CHANGELOG.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e2b85e7..b62f7aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,11 @@ +- 1.3.2 + - Fixed Sans Being passed through Extensions Data, Google does not like this. +- 1.3.1 + - SaaS containerization changes with Google Credentials +- 1.2.2 + - Fixed Sync Issues at CA Level, was ignoring and always syncing at pool level +- 1.2.1 + - Doc Updates - 1.2.0 - Added Enable Flag - Dual Build Support