fix(api/models): PAM ProviderType models Name to use string rather than pointer

Author: spbsoluble

v3/api/pam_test.go

@@ -190,7 +190,7 @@ func TestCreatePAMProvider(t *testing.T) {
 		Area:   1,
 		ProviderType: ProviderType{
 			Id:   mockProviderTypeId,
-			Name: &mockProviderTypeName,
+			Name: mockProviderTypeName,
 		},
 		SecuredAreaId: intPtr(1),
 	}
@@ -279,7 +279,7 @@ func TestUpdatePAMProvider(t *testing.T) {
 		Area:   1,
 		ProviderType: ProviderType{
 			Id:   mockProviderTypeId,
-			Name: &mockProviderTypeName,
+			Name: mockProviderTypeName,
 		},
 		SecuredAreaId: intPtr(1),
 	}
@@ -290,7 +290,7 @@ func TestUpdatePAMProvider(t *testing.T) {
 		Area: 1,
 		ProviderType: &ProviderType{
 			Id:   mockProviderTypeId,
-			Name: &mockProviderTypeName,
+			Name: mockProviderTypeName,
 		},
 		SecuredAreaId: intPtr(1),
 		Remote:        false,

v3/api/pam_types.go

@@ -60,7 +60,7 @@ func (c *Client) GetPAMProviderTypeByName(name string) (*ProviderTypeResponse, e
 
 	// find the provider type with the matching name
 	for _, t := range *types {
-		if t.Name != nil && *t.Name == name {
+		if t.Name == name {
 			return &t, nil
 		}
 	}

v3/api/pam_types_models.go

@@ -30,7 +30,7 @@ type SecretType int
 // ProviderTypeParameterResponse represents a parameter for a PAM provider type
 type ProviderTypeParameterResponse struct {
 	Id            int                  `json:"Id,omitempty"`
-	Name          *string              `json:"Name,omitempty"`
+	Name          string               `json:"Name,omitempty"`
 	DisplayName   *string              `json:"DisplayName,omitempty"`
 	DataType      PamParameterDataType `json:"DataType,omitempty"`
 	InstanceLevel bool                 `json:"InstanceLevel,omitempty"`
@@ -39,7 +39,7 @@ type ProviderTypeParameterResponse struct {
 // ProviderTypeResponse represents a PAM provider type
 type ProviderTypeResponse struct {
 	Id         string                           `json:"Id,omitempty"` // UUID format
-	Name       *string                          `json:"Name,omitempty"`
+	Name       string                           `json:"Name,omitempty"`
 	Parameters *[]ProviderTypeParameterResponse `json:"Parameters,omitempty"`
 }
 
@@ -60,15 +60,15 @@ type ProviderTypeCreateRequest struct {
 // ProviderCreateRequestProviderTypeParam represents a provider type parameter in a provider creation request
 type ProviderCreateRequestProviderTypeParam struct {
 	Id            int     `json:"Id,omitempty"`
-	Name          *string `json:"Name,omitempty"`
+	Name          string  `json:"Name,omitempty"`
 	DisplayName   *string `json:"DisplayName,omitempty"`
 	InstanceLevel bool    `json:"InstanceLevel,omitempty"`
 }
 
 // PamProviderTypeParam represents a provider type parameter (full model) for PAM operations
 type PamProviderTypeParam struct {
 	Id            int                  `json:"Id,omitempty"`
-	Name          *string              `json:"Name,omitempty"`
+	Name          string               `json:"Name,omitempty"`
 	DisplayName   *string              `json:"DisplayName,omitempty"`
 	DataType      PamParameterDataType `json:"DataType,omitempty"`
 	InstanceLevel bool                 `json:"InstanceLevel,omitempty"`
@@ -78,7 +78,7 @@ type PamProviderTypeParam struct {
 // ProviderType represents a PAM provider type (full model)
 type ProviderType struct {
 	Id                 string                  `json:"Id,omitempty"` // UUID format
-	Name               *string                 `json:"Name,omitempty"`
+	Name               string                  `json:"Name,omitempty"`
 	ProviderTypeParams *[]PamProviderTypeParam `json:"ProviderTypeParams,omitempty"`
 }
 

v3/api/pam_types_test.go

@@ -87,7 +87,7 @@ var (
 		Area: 1,
 		ProviderType: &ProviderType{
 			Id:   mockProviderTypeId,
-			Name: &mockProviderTypeName,
+			Name: mockProviderTypeName,
 		},
 		SecuredAreaId: intPtr(1),
 		Remote:        false,