Fix data race in xnn_set_fingerprint

dsharletg · xnnpack-bot · commit a73cde727305 · 2025-11-24T03:32:24.000-08:00
PiperOrigin-RevId: 836152217
diff --git a/src/operators/fingerprint_cache.c b/src/operators/fingerprint_cache.c
@@ -50,12 +50,11 @@ void xnn_set_fingerprint(const struct xnn_fingerprint fingerprint) {
       break;
     }
   }
-  xnn_mutex_unlock(&mutex);
-  if (i < fingerprint_vector_size) {
-    return;
+  if (i >= fingerprint_vector_size) {
+    assert(fingerprint_vector_size < XNN_FINGERPRINT_MAX_COUNT);
+    fingerprint_vector[fingerprint_vector_size++] = fingerprint;
   }
-  assert(fingerprint_vector_size < XNN_FINGERPRINT_MAX_COUNT);
-  fingerprint_vector[fingerprint_vector_size++] = fingerprint;
+  xnn_mutex_unlock(&mutex);
 }
 
 void xnn_clear_fingerprints() {

Original file line number	Diff line number	Diff line change
`@@ -50,12 +50,11 @@ void xnn_set_fingerprint(const struct xnn_fingerprint fingerprint) {`
`50`	`50`	`break;`
`51`	`51`	`}`
`52`	`52`	`}`
`53`		`- xnn_mutex_unlock(&mutex);`
`54`		`- if (i < fingerprint_vector_size) {`
`55`		`- return;`
	`53`	`+ if (i >= fingerprint_vector_size) {`
	`54`	`+ assert(fingerprint_vector_size < XNN_FINGERPRINT_MAX_COUNT);`
	`55`	`+ fingerprint_vector[fingerprint_vector_size++] = fingerprint;`
`56`	`56`	`}`
`57`		`- assert(fingerprint_vector_size < XNN_FINGERPRINT_MAX_COUNT);`
`58`		`- fingerprint_vector[fingerprint_vector_size++] = fingerprint;`
	`57`	`+ xnn_mutex_unlock(&mutex);`
`59`	`58`	`}`
`60`	`59`
`61`	`60`	`void xnn_clear_fingerprints() {`