[pull] master from wikimedia:master #560
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Localisation updates from https://translatewiki.net.
…s. (#2354) Co-authored-by: Sharvani Haran <[email protected]>
* Fix appending of namespace when launching Talk pages. * Improve general detection of namespaces. * Fix test. * Unnecessary parentheses. Co-authored-by: Sharvani Haran <[email protected]>
* Hygiene: remove unused class * Remove test case as well
* Kick it off. * Come on now. * Add details from summary endpoint. * Design refinements. * Add rounded corners. * Hook it all up. * Wire up publish workflow. * Randomize suggestions. * Stringify. * Couple of tweaks. * Variant B. * Come on. * Update designs. * More refinement. * Adapt to ErrorView changes. * Update for sticky design. * Add confirmation dialog selections. * Add analytics funnel. * Wire up funnel. * Add provision for teacher mode. * Correctly wire up scrolling detection. * Retry next item if current one doesn't exist. * Remove underscores from filename. * Add positive reinforcement mechanism. * Correctly reflect daily progress. * Document strings. * Make entire image into click target. * Remove dups. * Make it a timed funnel. * Update design of progress indicator. * Wire up onboarding tooltips. * Add onboarding. * Update dialog choices for No vs Unsure. * Add more stuff to funnel. * Track usage of info icon. * Document missing strings. * Adapt to updated TSV format. * Re-enable swiping. * Add initial tooltip. * Additional tweaks. * Fix checkstyle. * Update for new designs. * Update onboarding screens. * Go to correct FAQ URL. * Add proper sequencing of items. * Disallow editing file page when launching from image recs. * Fade in image suggestion when ready. * Increase duration of daily completion message. * Cleanup. * Show progress bar until everything is loaded. * Fix tooltip call. * Temporarily don't respond to IP blocking. * Add feature flag on enabled languages. * Bring up to date with schema. * Add "read more" button. * Fix typo. * Change target goal to 10. * Add another option for No and Not sure. * ImageRecs: resolve conflict files (#2269) * Convert onboarding activity and fragment to kotlin. * Cleanup. * Expand/collapse tables for find-in-page feature in PageFragment (#2195) * Apply toggleCollapsedForAll() for find-in-page feature in PageFragment * Fix lint * Fix lint #2 * Fix lint again * Add scripts to expand/collapse hideable tables * Update js content * Update parameter * Don't collaspe tables when exiting find-in-page Co-authored-by: Dmitry Brant <[email protected]> * Localisation updates from https://translatewiki.net. * Fix strings. * Convert BottomSheet related classes to Kotlin (#2253) Co-authored-by: Dmitry Brant <[email protected]> * Convert GeoMarshaller related classes to Kotlin (#2254) * Convert GeoMarshaller related classes to Kotlin * Use general parcel method to write * Remove unused import * Fix parceling null geo objects. Co-authored-by: Dmitry Brant <[email protected]> * Follow-up: add more tests for parcelizing hydrated PageProperties. (#2258) * Convert DescriptionEditTutorial to kotlin. * Convert DescriptionEditSuccess to kotlin. * Use Core KTX extensions. (#2256) * Use bundleOf(). * Use contentValuesOf(). * Use SQLiteDatabase.transaction() extension. * Use Context.withStyledAttributes() extensions. * Use Spanned and Spannable related extensions. Co-authored-by: Dmitry Brant <[email protected]> * Use FragmentManager.commit() extension. (#2255) Co-authored-by: Dmitry Brant <[email protected]> * Bump versionCode * Use inflater * Some code review changes * Localisation updates from https://translatewiki.net. (#2265) * Fix: crash when referenceGroup is null when opening ReferenceDialog (#2266) Co-authored-by: Dmitry Brant <[email protected]> Co-authored-by: translatewiki.net <[email protected]> Co-authored-by: Isira Seneviratne <[email protected]> * adjust dialog theme * Update design of Read More button. * Add text next to Info icon in toolbar. * Update design of task progress indicator. * Update design of image info button. * ImageRecs: update progress bar background (#2281) * Center image in container, with gradient background. * ImgRecs: change italics to bold on the "suggestion reason" (#2288) * ImgRecs: update tooltip XML layout to prevent content cutoff (#2285) * ImageRecs: show instruction text properly in small screen (#2275) * ImageRecs: show instruction text properly in small screen * Use Horizontal_bias * ImgRecs: prevent onboarding text being cutoff on small screen devices (#2294) * ImgRecs: code style hygiene (#2295) * Switch to using pageId in suggestion tables. * Highly optimize loading the entire dataset. * Correctly sequence the recommendations across restarts. * Nail down predictable randomization algorithm. * Reinstate IP block logic. * Disable swiping. * set up illustration images for all themes (#2298) * ImgRecs: tooltip textview lineHeight design tweak (#2297) * ImgRecs: tooltip textview lineHeight design tweak * Change arrow position * Adjust paddings * Remove unused imports * Use string resources * Image Recs: Success illustration (#2287) * Add a placeholder to the confetti image * no message * Update confetti image * Instrument Image Recommendations on MEP (#2290) * Solidify formatting of suggestion reasons. * Update border of success message * Updated images * Revert "Updated images" This reverts commit f9631f0. * Updated images * Add a border to image rec dialogs * Adding newline * Copy changes to 'No' and 'Not sure' dialogs * ImgRecs: prevent having null value in the langWikis list in ImageRecsFragment (#2314) * ImgRecs: prevent having null value in the langWikis list in ImageRecsFragment * Update funnel reason list * Put back onboarding to original place * Center the image with gravity * ImgRecs: make the dialog content scrollable for small (#2315) screen devices * ImgRecs: progress bar design tweaks (#2299) * ImgRecs: progress bar design tweaks * Make the prograss bar and checkmark thicker * Adjust icon size and border thickness * ImgRecs: FilePage tweaks for small screen devices (#2283) * ImgRecs: FilePage tweaks for small screen devices * Replace ellipsize to the end and set max length to 3 * Send suggestion reason to file page * Update icon of FAQ button. Change-Id: I83e027e46662fbf1a5cedd6725542502168f8a74 * Darken colors when using dark theme. Change-Id: I953824847cd5092844f79c6b66a5f8363ab672af * ImgRecs: add "Got it" button on sequential tooltips (#2318) * ImgRecs: add "Got it" button on sequential tooltips * Update got it button colors and gravity * Dialog margin update (#2322) * Lock orientation * Lock orientation (#2324) * Stretch success confetti to the whole screen * Fixed build * Update statusBar abd actionBar colors for confetti * fixed build * fixed build * fixed build * ImgRecs: make bottomsheet draggable (#2320) * ImgRecs: make bottomsheet draggable * Remove spacer * Apply setting in XML * Adjust peek height * Make the buttons fixed * Make default to collapse * Remove fixed buttons and collapse bottomsheet when title is overlapped * ImgRecs: tooltip bottom margin tweaks (#2327) * ImgRecs: reduce file page top margin (#2328) * ImgRecs: adjust file page top margin * Update order * CR comments addressed * Updated attribute names and colors and updated navigation bar colors for all 4 modes * ImgRecs: make fake touch event when zooming image (#2339) * Update distribution constant * value repeated * ImgRecs: progressView design tweaks (#2342) * ImgRecs: progressView design tweaks * Optimize animations * Remove unused import * Update navbar color * Use new asset of bolt icon * Adjust times * Adjust showing time * Final showing time tweak * A screenSize specific fix to make the onboarding image visible on small screen * ImgRecs: don't block the feed if title is empty (#2346) * ImgRecs: don't block the feed if title is empty * Fix lint * Fix lint #2 * Naming fix * ImgRecs: throw proper exception and provide a proper button for going to (#2348) next item * ImgRecs: follow up: detect onboarding view height for small screen device (#2350) * Follow up: detect onboarding view height for small screen device * Remove unused val * Use proper width * Use correct history source. * Fix bolt icon (increase miter limit). * ImgRecs: check and update daily count in SE task screen (#2355) * ImgRecs: check and update daily count in SE task screen * Update string * Update image recs daily count properly * Remove local asset. * Introduce submodule for imagerecs assets. * Update assets path for image recs. * Update supported languages. * Check only topmost language. * ImgRecs: code style clean up and optimize (#2358) Co-authored-by: Dmitry Brant <[email protected]> * ImgRecs: remove commented out code (#2356) Co-authored-by: Cooltey Feng <[email protected]> Co-authored-by: translatewiki.net <[email protected]> Co-authored-by: Isira Seneviratne <[email protected]> Co-authored-by: sharvani <[email protected]> Co-authored-by: Sharvani Haran <[email protected]> Co-authored-by: cooltey <[email protected]>
Co-authored-by: Sharvani Haran <[email protected]>
* Fix fetching of CSRF tokens for anonymous editing. * Optimize logic.
* Don't check for IP block when not logged in. * Query home wiki for blockage, too. Co-authored-by: Sharvani Haran <[email protected]>
Change-Id: Id21fd0f1cb4b244bab328f05995cd0fb5f160ddc
Change-Id: I9bf3fc4a4d97401f80a929b06ff21da607f09ae0
Bump versionCode
* Fix and improve tooltip sequencing on Main screen. * Clean up. Co-authored-by: Cooltey Feng <[email protected]>
* Remove stream name regex-matching EventStreamConfigs supports defining rules for streams with names that match (JavaScript) regular expressions. However, this is only used in practice for job-queue-related jobs, and the app need not support it. * Send events immediately for testing Sends events immediately upon submission to the MEP client to match the legacy eventlogging behavior. We'll compare the resulting events with those sent via the legacy system in order to determine conclusively whether events are being leaked in the queueing process. Phab: https://phabricator.wikimedia.org/T281001 Co-authored-by: Sharvani Haran <[email protected]>
Co-authored-by: Cooltey Feng <[email protected]>
* Bump versionCode * Bump versionCode * Bump versionCode
* Convert ConfigureItemView to Kotlin * Copy list
* Convert NewsItemView to Kotlin * single line Co-authored-by: Sharvani Haran <[email protected]>
#2433) Co-authored-by: Sharvani Haran <[email protected]>
* Kotlin Conversion: OnThisDayPagesViewHolder * Kotlin Conversion: OnThisDayActivity * OnthisdayFragment cconverted * Updated Otd code * Code-clean-up * Code-clean-up Co-authored-by: Cooltey Feng <[email protected]>
Localisation updates from https://translatewiki.net.
* Convert additional Editing classes to kotlin. * Fully qualify. * Streamline. Co-authored-by: Cooltey Feng <[email protected]>
* Convert additional Editing classes to kotlin. * Fully qualify. * Streamline. * Follow up: edit classes Kotlin conversion * Fix lint Co-authored-by: Dmitry Brant <[email protected]>
Co-authored-by: Dmitry Brant <[email protected]>
* Convert MostRead fragment and activity to Kotlin * Remove Jvm annotation * Fix title bar Co-authored-by: Dmitry Brant <[email protected]>
Co-authored-by: Sharvani Haran <[email protected]> Co-authored-by: Dmitry Brant <[email protected]>
…#2436) Co-authored-by: Dmitry Brant <[email protected]>
Localisation updates from https://translatewiki.net.
Localisation updates from https://translatewiki.net.
* Rename .java to .kt * Convert UtcDate model to Kotlin * Address code review of UtcDate Co-authored-by: Triet Bui <[email protected]> Co-authored-by: Dmitry Brant <[email protected]>
* Convert ConfigureFragment to Kotlin * Simplify a bit Co-authored-by: Dmitry Brant <[email protected]>
Co-authored-by: Cooltey Feng <[email protected]>
Co-authored-by: Cooltey Feng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )