cggmp24: security fix #168

survived · 2025-11-24T10:48:42Z

No description provided.

Signed-off-by: Denis Varlakov <[email protected]>

Forbid presigs when they are not safe

…-fix

Signed-off-by: Denis Varlakov <[email protected]>

Add security checks

Signed-off-by: Denis Varlakov <[email protected]>

Add `Send + Sync` supertraits to `AnyDataToSign`

github-actions · 2025-11-24T10:49:08Z

Crate direct deps

Direct deps

cggmp24-keygen v0.7.0-alpha.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp24-keygen)
digest v0.10.6
futures v0.3.24
generic-ec v0.4.1
generic-ec-zkp v0.4.1
hex v0.4.3
key-share v0.6.1 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
paillier-zk v0.7.0-alpha.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/paillier-zk)
rand_core v0.6.4
rand_hash v0.1.0
round-based v0.4.1
serde v1.0.193
serde_with v2.3.3
sha2 v0.10.6
thiserror v1.0.48
udigest v0.2.1

Compared to base branch

Diff

--- direct-deps-base	2025-11-24 10:56:46.011712308 +0000
+++ direct-deps-pr	2025-11-24 10:56:46.311713822 +0000
@@ -1 +1 @@
-cggmp24-keygen v0.7.0-alpha.1 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp24-keygen)
+cggmp24-keygen v0.7.0-alpha.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp24-keygen)
@@ -7,2 +7,2 @@
-key-share v0.6.1 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share)
-paillier-zk v0.7.0-alpha.1 (/home/runner/work/cggmp21/cggmp21/base_branch/paillier-zk)
+key-share v0.6.1 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
+paillier-zk v0.7.0-alpha.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/paillier-zk)

All deps

cargo tree

cggmp24 v0.7.0-alpha.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp24)
�[2m├──�[0m cggmp24-keygen v0.7.0-alpha.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp24-keygen)
�[2m│�[0m   �[2m├──�[0m digest v0.10.6
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m block-buffer v0.10.3
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m generic-array v0.14.6
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m serde v1.0.193
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m└──�[0m serde_derive v1.0.193 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m proc-macro2 v1.0.92
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m└──�[0m unicode-ident v1.0.4
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m quote v1.0.37
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m└──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m syn v2.0.90
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m└──�[0m unicode-ident v1.0.4
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m typenum v1.15.0
�[2m│�[0m   �[2m│�[0m   �[2m└──�[0m crypto-common v0.1.6
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m generic-array v0.14.6 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m typenum v1.15.0
�[2m│�[0m   �[2m├──�[0m displaydoc v0.2.5 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m└──�[0m syn v2.0.90 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m futures-util v0.3.24
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m futures-core v0.3.24
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m futures-sink v0.3.24
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m futures-task v0.3.24
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m pin-project-lite v0.2.9
�[2m│�[0m   �[2m│�[0m   �[2m└──�[0m pin-utils v0.1.0
�[2m│�[0m   �[2m├──�[0m generic-ec v0.4.1
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m digest v0.10.6 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m generic-ec-core v0.2.0
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m generic-array v0.14.6 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m rand_core v0.6.4
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m serde v1.0.193 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m subtle v2.4.1
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m zeroize v1.6.0
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m zeroize_derive v1.3.2 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m├──�[0m syn v1.0.101
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m│�[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m│�[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m│�[0m   �[2m└──�[0m unicode-ident v1.0.4
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m└──�[0m synstructure v0.12.6
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m �[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m �[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m �[0m   �[2m├──�[0m syn v1.0.101 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m �[0m   �[2m└──�[0m unicode-xid v0.2.4
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m hex v0.4.3
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m serde v1.0.193 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m phantom-type v0.4.2
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m educe v0.4.19 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m enum-ordinalize v3.1.11 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m├──�[0m num-bigint v0.4.3
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m num-integer v0.1.45
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m num-traits v0.2.15
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m num-traits v0.2.15
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m├──�[0m num-traits v0.2.15
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m└──�[0m syn v1.0.101 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m syn v1.0.101 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m rand_core v0.6.4
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m rand_hash v0.1.0
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m digest v0.10.6 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m rand_core v0.6.4
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m udigest v0.2.1
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m digest v0.10.6 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m udigest-derive v0.3.0 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m└──�[0m syn v2.0.90 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m serde v1.0.193 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m serde_with v2.3.3
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m serde v1.0.193 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m serde_with_macros v2.3.3 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m darling v0.20.1
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m├──�[0m darling_core v0.20.1
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m fnv v1.0.7
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m ident_case v1.0.1
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m strsim v0.10.0
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m syn v2.0.90 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m└──�[0m darling_macro v0.20.1 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m darling_core v0.20.1 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m syn v2.0.90 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m syn v2.0.90 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m subtle v2.4.1
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m udigest v0.2.1 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m└──�[0m zeroize v1.6.0 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m generic-ec-zkp v0.4.1
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m generic-array v0.14.6 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m generic-ec v0.4.1 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m rand_core v0.6.4
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m serde v1.0.193 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m subtle v2.4.1
�[2m│�[0m   �[2m│�[0m   �[2m└──�[0m udigest v0.2.1 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m hex v0.4.3 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m key-share v0.6.1 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m displaydoc v0.2.5 (proc-macro) �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m generic-ec v0.4.1 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m generic-ec-zkp v0.4.1 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m hex v0.4.3 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m serde v1.0.193 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m serde_with v2.3.3 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m└──�[0m thiserror v1.0.48
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m thiserror-impl v1.0.48 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m �[0m   �[2m└──�[0m syn v2.0.90 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m rand_core v0.6.4
�[2m│�[0m   �[2m├──�[0m round-based v0.4.1
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m futures-util v0.3.24 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m phantom-type v0.3.1
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m educe v0.4.19 (proc-macro) �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m round-based-derive v0.2.2 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m syn v1.0.101 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m thiserror v2.0.4
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m thiserror-impl v2.0.4 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m syn v2.0.90 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m└──�[0m tracing v0.1.36
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m cfg-if v1.0.0
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m pin-project-lite v0.2.9
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m tracing-core v0.1.29
�[2m│�[0m   �[2m├──�[0m serde v1.0.193 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m serde_with v2.3.3 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m sha2 v0.10.6
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m cfg-if v1.0.0
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m cpufeatures v0.2.12
�[2m│�[0m   �[2m│�[0m   �[2m└──�[0m digest v0.10.6 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m thiserror v1.0.48 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m└──�[0m udigest v0.2.1 �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m digest v0.10.6 �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m futures v0.3.24
�[2m│�[0m   �[2m├──�[0m futures-channel v0.3.24
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m futures-core v0.3.24
�[2m│�[0m   �[2m│�[0m   �[2m└──�[0m futures-sink v0.3.24
�[2m│�[0m   �[2m├──�[0m futures-core v0.3.24
�[2m│�[0m   �[2m├──�[0m futures-io v0.3.24
�[2m│�[0m   �[2m├──�[0m futures-sink v0.3.24
�[2m│�[0m   �[2m├──�[0m futures-task v0.3.24
�[2m│�[0m   �[2m└──�[0m futures-util v0.3.24 �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m generic-ec v0.4.1 �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m generic-ec-zkp v0.4.1 �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m hex v0.4.3 �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m key-share v0.6.1 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share) �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m paillier-zk v0.7.0-alpha.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/paillier-zk)
�[2m│�[0m   �[2m├──�[0m digest v0.10.6 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m fast-paillier v0.1.1
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m bytemuck v1.13.1
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m bytemuck_derive v1.4.1 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m syn v2.0.90 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m rand_core v0.6.4
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m rug v1.27.0
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m az v1.2.1
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m gmp-mpfr-sys v1.6.1
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m libc v0.2.153
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m libc v0.2.153
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m├──�[0m libm v0.2.15
�[2m│�[0m   �[2m│�[0m   �[2m│�[0m   �[2m└──�[0m serde v1.0.193 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m serde v1.0.193 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m└──�[0m thiserror v1.0.48 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m generic-ec v0.4.1 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m rand_core v0.6.4
�[2m│�[0m   �[2m├──�[0m rand_hash v0.1.0 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m rug v1.27.0 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m serde v1.0.193 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m serde_with v3.0.0
�[2m│�[0m   �[2m│�[0m   �[2m├──�[0m serde v1.0.193 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m└──�[0m serde_with_macros v3.0.0 (proc-macro)
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m darling v0.20.1 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m proc-macro2 v1.0.92 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m├──�[0m quote v1.0.37 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m│�[0m   �[2m �[0m   �[2m└──�[0m syn v2.0.90 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m├──�[0m thiserror v1.0.48 �[33m�[2m(*)�[39m�[22m
�[2m│�[0m   �[2m└──�[0m udigest v0.2.1 �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m rand_core v0.6.4
�[2m├──�[0m rand_hash v0.1.0 �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m round-based v0.4.1 �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m serde v1.0.193 �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m serde_with v2.3.3 �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m sha2 v0.10.6 �[33m�[2m(*)�[39m�[22m
�[2m├──�[0m thiserror v1.0.48 �[33m�[2m(*)�[39m�[22m
�[2m└──�[0m udigest v0.2.1 �[33m�[2m(*)�[39m�[22m

Compared to base branch

Diff

--- all-deps-base	2025-11-24 10:56:46.157713045 +0000
+++ all-deps-pr	2025-11-24 10:56:46.462714584 +0000
@@ -6 +6 @@
-cggmp24-keygen v0.7.0-alpha.1 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp24-keygen)
+cggmp24-keygen v0.7.0-alpha.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp24-keygen)
@@ -42,2 +42,2 @@
-key-share v0.6.1 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share)
-key-share v0.6.1 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share) �[33m�[2m(*)�[39m�[22m
+key-share v0.6.1 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
+key-share v0.6.1 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share) �[33m�[2m(*)�[39m�[22m
@@ -49 +49 @@
-paillier-zk v0.7.0-alpha.1 (/home/runner/work/cggmp21/cggmp21/base_branch/paillier-zk)
+paillier-zk v0.7.0-alpha.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/paillier-zk)

Signed-off-by: Denis Varlakov <[email protected]>

github-actions · 2025-11-24T10:50:16Z

The spec was successfully compiled. PDF is available here.

github-actions · 2025-11-24T10:52:20Z

Benchmark Result

Benchmarks

RUST_TESTS_SEED=ca7cc4981c4108f3de2d352bd35f95cf6be408a895ace3c2fce9bd7ed4993b07
n = 3

Non-threshold DKG
Protocol Performance:
  - Protocol took 558.66µs to complete
In particular:
  - Stage: 5.75µs
    - Setup networking: 5.49µs (95.5%)
    - Unstaged: 261.00ns (4.5%)
  - Round 1: 167.39µs
    - Sample x_i, rid_i, chain_code: 64.90µs (38.8%)
    - Sample schnorr commitment: 77.40µs (46.2%)
    - Commit to public data: 24.80µs (14.8%)
    - Unstaged: 291.00ns (0.2%)
  - Round 2: 1.30µs
    - Hash received msgs (reliability check): 1.15µs (88.5%)
    - Unstaged: 150.00ns (11.5%)
  - Round 3: 290.00ns
    - Assert other parties hashed messages (reliability check): 180.00ns (62.1%)
    - Unstaged: 110.00ns (37.9%)
  - Round 4: 67.39µs
    - Validate decommitments: 32.79µs (48.7%)
    - Calculate chain_code: 811.00ns (1.2%)
    - Calculate challege rid: 33.45µs (49.6%)
    - Prove knowledge of `x_i`: 200.00ns (0.3%)
    - Unstaged: 131.00ns (0.2%)
  - Round 5: 316.55µs
    - Validate schnorr proofs: 316.13µs (99.9%)
    - Unstaged: 420.00ns (0.1%)


Threshold DKG
Protocol Performance:
  - Protocol took 1.32ms to complete
In particular:
  - Stage: 1.80µs
    - Setup networking: 1.75µs (97.2%)
    - Unstaged: 50.00ns (2.8%)
  - Round 1: 201.39µs
    - Sample rid_i, schnorr commitment, polynomial, chain_code: 176.33µs (87.6%)
    - Commit to public data: 24.87µs (12.3%)
    - Unstaged: 191.00ns (0.1%)
  - Round 2: 1.27µs
    - Hash received msgs (reliability check): 1.11µs (87.4%)
    - Unstaged: 161.00ns (12.6%)
  - Round 3: 351.00ns
    - Assert other parties hashed messages (reliability check): 231.00ns (65.8%)
    - Unstaged: 120.00ns (34.2%)
  - Round 4: 811.42µs
    - Validate decommitments: 48.85µs (6.0%)
    - Validate data size: 170.00ns (0.0%)
    - Validate Feldmann VSS: 351.96µs (43.4%)
    - Compute rid: 170.00ns (0.0%)
    - Compute chain_code: 611.00ns (0.1%)
    - Compute Ys: 375.54µs (46.3%)
    - Compute sigma: 421.00ns (0.1%)
    - Calculate challenge: 33.04µs (4.1%)
    - Prove knowledge of `sigma_i`: 481.00ns (0.1%)
    - Unstaged: 180.00ns (0.0%)
  - Round 5: 299.81µs
    - Validate schnorr proofs: 298.59µs (99.6%)
    - Derive resulting public key and other data: 952.00ns (0.3%)
    - Unstaged: 261.00ns (0.1%)


Auxiliary data generation protocol
Protocol Performance:
  - Protocol took 9.55s to complete
In particular:
  - Stage: 16.30µs
    - Retrieve auxiliary data: 180.00ns (1.1%)
    - Setup networking: 16.06µs (98.5%)
    - Unstaged: 60.00ns (0.4%)
  - Round 1: 1.15s
    - Build Paillier key: 2.07µs (0.0%)
    - Build Pedersen params: 2.72ms (0.2%)
    - Prove Πprm (ψˆ_i): 1.15s (99.7%)
    - Sample random bytes: 1.45µs (0.0%)
    - Compute hash commitment and sample decommitment: 321.33µs (0.0%)
    - Unstaged: 271.00ns (0.0%)
  - Round 2: 2.04µs
    - Hash received msgs (reliability check): 1.63µs (79.9%)
    - Unstaged: 410.00ns (20.1%)
  - Round 3: 471.00ns
    - Assert other parties hashed messages (reliability check): 331.00ns (70.3%)
    - Unstaged: 140.00ns (29.7%)
  - Round 4: 5.96s
    - Validate round 1 decommitments: 611.61µs (0.0%)
    - Validate bit length and П_prm (ψˆ_i): 2.30s (38.7%)
    - Add together shared random bytes: 1.49µs (0.0%)
    - Compute П_mod (ψ_i): 3.47s (58.3%)
    - Assemble security params for П_fac (ψ_i): 7.36µs (0.0%)
    - Compute П_fac (ψ'_i,j): 183.01ms (3.1%)
    - Unstaged: 931.00ns (0.0%)
  - Round 5: 2.44s
    - Validate ψ_j (П_mod): 2.34s (96.2%)
    - Validate ψ'_j,i (П_fac): 91.41ms (3.8%)
    - Assemble auxiliary info: 161.35µs (0.0%)
    - Unstaged: 1.15µs (0.0%)


Signing protocol
Protocol Performance:
  - Protocol took 1.42s to complete
In particular:
  - Stage: 157.08µs
    - Map t-out-of-n protocol to t-out-of-t: 87.27µs (55.6%)
    - Retrieve auxiliary data: 65.48µs (41.7%)
    - Precompute execution id and security params: 91.00ns (0.1%)
    - Setup networking: 4.12µs (2.6%)
    - Unstaged: 120.00ns (0.1%)
  - Round 1: 209.19ms
    - Generate local ephemeral secrets (k_i, y_i, p_i, v_i): 49.62µs (0.0%)
    - Encrypt G_i and K_i: 35.94ms (17.2%)
    - Generate a_i, b_i, A_i1, A_i2, B_i1, B_i2: 414.76µs (0.2%)
    - Prove psi0_ji, psi1_ji: 172.79ms (82.6%)
    - Unstaged: 612.00ns (0.0%)
  - Round 2: 133.39µs
    - Hash received msgs (reliability check): 133.13µs (99.8%)
    - Unstaged: 261.00ns (0.2%)
  - Round 3: 771.96ms
    - Assert other parties hashed messages (reliability check): 1.29µs (0.0%)
    - Verify psi0, psi1 proofs: 99.73ms (12.9%)
    - Prove tilde_psi_i: 374.33µs (0.0%)
    - Sample random r, hat_r, s, hat_s, beta, hat_beta: 16.10µs (0.0%)
    - Encrypt D_ji: 70.70ms (9.2%)
    - Encrypt F_ji: 35.92ms (4.7%)
    - Encrypt hat_D_ji: 70.64ms (9.2%)
    - Encrypt hat_F_ji: 35.90ms (4.7%)
    - Prove psi_ji: 229.12ms (29.7%)
    - Prove psiˆ_ji: 229.57ms (29.7%)
    - Unstaged: 2.55µs (0.0%)
  - Round 4: 439.43ms
    - Retrieve auxiliary data: 1.63µs (0.0%)
    - Validate tilde_psi_j: 1.09ms (0.2%)
    - Validate psi_i,j: 182.71ms (41.6%)
    - Validate hat_psi_i,j: 182.85ms (41.6%)
    - Compute Gamma, Delta_i, delta_i, chi_i: 72.42ms (16.5%)
    - Prove psi_prime: 368.85µs (0.1%)
    - Unstaged: 821.00ns (0.0%)
  - Presig output: 1.57ms
    - Validate psi_prime_prime: 1.08ms (69.0%)
    - Calculate presignature: 484.99µs (30.9%)
    - Unstaged: 1.78µs (0.1%)
  - Partial signing: 8.04µs
  - Signature reconstruction: 542.49µs

Signed-off-by: Denis Varlakov <[email protected]>

survived added 21 commits August 14, 2025 10:48

Forbid presigs + raw signing

9d98157

Signed-off-by: Denis Varlakov <[email protected]>

Update docs

af1e487

Signed-off-by: Denis Varlakov <[email protected]>

Update docs

12b253e

Signed-off-by: Denis Varlakov <[email protected]>

Forbig presigs + HD wallets

614c78d

Signed-off-by: Denis Varlakov <[email protected]>

Clearify docs further

7c5e906

Signed-off-by: Denis Varlakov <[email protected]>

Update doc duplicate

d6f65ab

Signed-off-by: Denis Varlakov <[email protected]>

Merge pull request #7 from dfnsco/cggmp24/forbid-presigs-when-not-safe

b46d747

Forbid presigs when they are not safe

Merge remote-tracking branch 'origin/cggmp24/m' into cggmp24/security…

d527af2

…-fix

Add more checks into Pi_enc

a1b7dc6

Signed-off-by: Denis Varlakov <[email protected]>

Add a parameter q to security params that replaces generics on E

b8fe0dc

Signed-off-by: Denis Varlakov <[email protected]>

review: update enc proof

92001df

Signed-off-by: Denis Varlakov <[email protected]>

Add a comment about challenge domain in elog proof

5f3c0e2

Signed-off-by: Denis Varlakov <[email protected]>

Add missing checks into aff-g proof

fd81bb8

Signed-off-by: Denis Varlakov <[email protected]>

Add missing checks into mod proof

637c919

Signed-off-by: Denis Varlakov <[email protected]>

fixup: mod proof

c77db5d

Signed-off-by: Denis Varlakov <[email protected]>

Add missing checks into prm proof

26f091c

Signed-off-by: Denis Varlakov <[email protected]>

Add missing checks into prm proof

1a1042f

Signed-off-by: Denis Varlakov <[email protected]>

Add missing checks into enc-elg proof

803061e

Signed-off-by: Denis Varlakov <[email protected]>

Merge pull request #10 from dfnsco/add-checks

5ae07ff

Add security checks

Add Send + Sync supertraits to AnyDataToSign

5c93b41

Signed-off-by: Denis Varlakov <[email protected]>

Merge pull request #11 from dfnsco/add-supertrait

44f1925

Add `Send + Sync` supertraits to `AnyDataToSign`

alpha.2: migration and changelog

7b70cf9

Signed-off-by: Denis Varlakov <[email protected]>

survived force-pushed the cggmp24/security-fix branch from f76f321 to 7b70cf9 Compare November 24, 2025 10:51

survived added 2 commits November 24, 2025 11:52

Fix docs build

eea2be0

Signed-off-by: Denis Varlakov <[email protected]>

Bump versions

1533e87

Signed-off-by: Denis Varlakov <[email protected]>

maurges approved these changes Nov 24, 2025

View reviewed changes

survived merged commit 0267d9c into cggmp24/m Nov 24, 2025
23 checks passed

survived deleted the cggmp24/security-fix branch November 24, 2025 11:08

survived mentioned this pull request Nov 25, 2025

Update variable names in ZK aff-g and fix minor typos #163

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

cggmp24: security fix #168

cggmp24: security fix #168

Uh oh!

survived commented Nov 24, 2025

Uh oh!

github-actions bot commented Nov 24, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 24, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cggmp24: security fix #168

cggmp24: security fix #168

Uh oh!

Conversation

survived commented Nov 24, 2025

Uh oh!

github-actions bot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Crate direct deps

Compared to base branch

All deps

Compared to base branch

Uh oh!

github-actions bot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Result

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Nov 24, 2025 •

edited

Loading

github-actions bot commented Nov 24, 2025 •

edited

Loading

github-actions bot commented Nov 24, 2025 •

edited

Loading