Merge pull request #78 from pollastri-pierre/fix/rbf

Add bindings for BitcoinLikeOutput::isReplaceable()

Author: gre

include/BitcoinLikeOutput.hpp

@@ -63,6 +63,14 @@ class LIBCORE_EXPORT BitcoinLikeOutput {
     virtual std::shared_ptr<DerivationPath> getDerivationPath() = 0;
 
     virtual std::experimental::optional<int64_t> getBlockHeight() = 0;
+
+    /**
+     * Check if the transaction (which created this output) is replaceable (RBF).
+     * An output can be replaceable if the transaction has at least one RBF input
+     * and if the transaction is not a block.
+     * @return true if the output is replaceable, false otherwise
+     */
+    virtual bool isReplaceable() const = 0;
 };
 
 } } }  // namespace ledger::core::api

include/CosmosConfigurationDefaults.cpp

@@ -5,7 +5,7 @@
 
 namespace ledger { namespace core { namespace api {
 
-std::string const CosmosConfigurationDefaults::COSMOS_DEFAULT_API_ENDPOINT = {"http://lite-client-0e27eefb-4031-4859-a88e-249fd241989d.cosmos.bison.run:1317"};
+std::string const CosmosConfigurationDefaults::COSMOS_DEFAULT_API_ENDPOINT = {"https://cosmos.coin.staging.aws.ledger.com"};
 
 std::string const CosmosConfigurationDefaults::COSMOS_OBSERVER_WS_ENDPOINT = {""};
 

src/NJSBitcoinLikeOutputCpp.cpp

@@ -225,6 +225,31 @@ NAN_METHOD(NJSBitcoinLikeOutput::getBlockHeight) {
     }
 
 
+    //Return result
+    info.GetReturnValue().Set(arg_0);
+}
+NAN_METHOD(NJSBitcoinLikeOutput::isReplaceable) {
+
+    //Check if method called with right number of arguments
+    if(info.Length() != 0)
+    {
+        return Nan::ThrowError("NJSBitcoinLikeOutput::isReplaceable needs 0 arguments");
+    }
+
+    //Check if parameters have correct types
+
+    //Unwrap current object and retrieve its Cpp Implementation
+    auto cpp_impl = djinni::js::ObjectWrapper<ledger::core::api::BitcoinLikeOutput>::Unwrap(info.This());
+    if(!cpp_impl)
+    {
+        return Nan::ThrowError("NJSBitcoinLikeOutput::isReplaceable : implementation of BitcoinLikeOutput is not valid");
+    }
+
+    auto result = cpp_impl->isReplaceable();
+
+    //Wrap result in node object
+    auto arg_0 = Nan::New<Boolean>(result);
+
     //Return result
     info.GetReturnValue().Set(arg_0);
 }
@@ -282,6 +307,7 @@ void NJSBitcoinLikeOutput::Initialize(Local<Object> target) {
     Nan::SetPrototypeMethod(func_template,"getAddress", getAddress);
     Nan::SetPrototypeMethod(func_template,"getDerivationPath", getDerivationPath);
     Nan::SetPrototypeMethod(func_template,"getBlockHeight", getBlockHeight);
+    Nan::SetPrototypeMethod(func_template,"isReplaceable", isReplaceable);
     Nan::SetPrototypeMethod(func_template,"isNull", isNull);
     //Set object prototype
     BitcoinLikeOutput_prototype.Reset(objectTemplate);

src/NJSBitcoinLikeOutputCpp.hpp

@@ -69,6 +69,14 @@ class NJSBitcoinLikeOutput final {
 
     static NAN_METHOD(getBlockHeight);
 
+    /**
+     * Check if the transaction (which created this output) is replaceable (RBF).
+     * An output can be replaceable if the transaction has at least one RBF input
+     * and if the transaction is not a block.
+     * @return true if the output is replaceable, false otherwise
+     */
+    static NAN_METHOD(isReplaceable);
+
     static NAN_METHOD(New);
 
     static NAN_METHOD(isNull);

src/ledgercore_doc.js

@@ -3261,6 +3261,13 @@ declare class NJSBitcoinLikeOutput
     declare function getAddress(): ?string;
     declare function getDerivationPath(): ?NJSDerivationPath;
     declare function getBlockHeight(): ?number;
+    /**
+     * Check if the transaction (which created this output) is replaceable (RBF).
+     * An output can be replaceable if the transaction has at least one RBF input
+     * and if the transaction is not a block.
+     * @return true if the output is replaceable, false otherwise
+     */
+    declare function isReplaceable(): boolean;
 }
 /** Class representing Bitcoin block */
 declare class NJSBitcoinLikeBlock