Skip to content

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented Jan 23, 2022

Closes None.

Changes proposed in this pull request:

  • Skip bad runs instead of failing when they exist.
  • Allow subsets of analyses.
  • Use TQDM to log the progress of null distribution permutations.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #9 (4ddd67d) into main (16db6fb) will decrease coverage by 4.33%.
The diff coverage is 5.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   21.19%   16.86%   -4.34%     
==========================================
  Files           6        6              
  Lines         335      510     +175     
==========================================
+ Hits           71       86      +15     
- Misses        264      424     +160     
Impacted Files Coverage Δ
ddmra/plotting.py 18.36% <0.00%> (-1.64%) ⬇️
ddmra/workflows.py 4.87% <0.00%> (-6.49%) ⬇️
ddmra/utils.py 32.21% <16.32%> (-1.79%) ⬇️
ddmra/analysis.py 16.88% <18.42%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16db6fb...4ddd67d. Read the comment docs.

tsalo added 14 commits January 26, 2022 11:26
This reverts commit f123fdb.
Currently we smooth analysis values and null distributions across distances *before* evaluating significance, which seems to me to enhance significance. This change calculates the rank for each edge against its own null distribution before averaging across distances.

Basically, this shifts from averaging, then ranking, to ranking, then averaging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants