-
Notifications
You must be signed in to change notification settings - Fork 7
Bump factory revision (rebuild against flint 3.4.0) #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| sha256 "345ec8ab2481135d18244e2a2ff6bc16e812a39a9eb5ac5d578956d8e0526e6e" | ||
| license any_of: ["GPL-2.0-only", "GPL-3.0-only"] | ||
| revision 2 | ||
| revision 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you bump more than once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had already bumped to a revision 3 to add tahoe packages a couple weeks ago, but you suggested that I revert those changes. But that bottle had already been uploaded, I guess, so the "pr-pull" step for this PR failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I guess brew audit wants the revision to increment by exactly 1. I guess we should delete the old revision 3 bottle. It doesn't look like I have the right permissions. @mahrud - do you? Or is this something we need to bug Mike about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be only possible using oras.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the docs there's a delete button for folks with the right permissions.
@mikestillman - do you have the option of deleting the 4.4.1_3 factory bottle on https://github.com/Macaulay2/homebrew-tap/pkgs/container/tap%2Ffactory/versions?filters%5Bversion_type%5D=tagged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came up with a dumb solution: I bumped the factory revision on the main branch to 3 so that we could bump it to 4 here without brew audit complaining.
@mikestillman - Don't worry about deleting that bottle.
This should fix the current failing builds in the M2 repo, e.g., from https://github.com/Macaulay2/M2/actions/runs/19684168550/job/56385474365?pr=4040: