Skip to content

Conversation

@mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented Sep 24, 2024

Rendered article sections for review:

AB#54156161

@mikehoffms mikehoffms added in-progress cat: webview2 WebView-related content. labels Sep 24, 2024
@mikehoffms mikehoffms marked this pull request as ready for review October 17, 2024 03:25
Copy link
Collaborator Author

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Writer/Editor

Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@peiche-ms peiche-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 3f4f5c0:

💡 Validation status: suggestions

File Status Preview URL Details
microsoft-edge/webview2/release-notes/index.md 💡Suggestion View Details
media/notes.png ✅Succeeded n/a (file deleted or renamed)
media/part1-badge.png ✅Succeeded n/a (file deleted or renamed)

microsoft-edge/webview2/release-notes/index.md

  • Line 246, Column 7: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2environment.restartrequested?view=webview2-dotnet-1.0.2895-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 249, Column 7: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2restartrequestedeventargs.priority?view=webview2-dotnet-1.0.2895-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 251, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2restartrequestedpriority?view=webview2-dotnet-1.0.2895-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@captainbrosset captainbrosset merged commit 6415ae6 into main Oct 22, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/relnotes-oct-2024 branch October 22, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat: webview2 WebView-related content.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants