chore: remove assertions that are now covered by type checking

Author: tysmith

src/grizzly/common/fuzzmanager.py

@@ -56,7 +56,6 @@ def __init__(self, crash_id: int) -> None:
         Arguments:
             crash_id: ID of the requested crash on the server side
         """
-        assert isinstance(crash_id, int)
         self._crash_id = crash_id
         self._coll = Collector()
         self._contents: list[Path] | None = None
@@ -128,7 +127,6 @@ def _subset(tests: list[Path], subset: list[int]) -> list[Path]:
         Returns:
             Directories that have been selected.
         """
-        assert isinstance(subset, list)
         assert tests
         count = len(tests)
         # deduplicate and limit requested indices to valid range
@@ -273,7 +271,6 @@ def __init__(self, bucket_id: int) -> None:
         Arguments:
             bucket_id: ID of the requested bucket on the server.
         """
-        assert isinstance(bucket_id, int)
         self._bucket_id = bucket_id
         self._sig_filename: Path | None = None
         self._coll = Collector()

src/grizzly/common/plugins.py

@@ -29,7 +29,6 @@ def load_plugin(name: str, group: str, base_type: type) -> Any:
     Returns:
         Loaded plug-in object.
     """
-    assert isinstance(base_type, type)
     for entry in iter_entry_points(group):
         if entry.name == name:
             plugin = entry.load()

src/grizzly/common/reporter.py

@@ -221,7 +221,6 @@ def add_extra_metadata(self, key: str, value: Any) -> None:
         Returns:
             None
         """
-        assert isinstance(key, str)
         assert key not in self._extra_metadata
         # deep copy and ensure that value is JSON serializable
         self._extra_metadata[key] = loads(dumps(value))

src/grizzly/common/stack_hasher.py

@@ -480,7 +480,6 @@ def height_limit(self) -> int:
 
     @height_limit.setter
     def height_limit(self, value: int) -> None:
-        assert isinstance(value, int)
         assert value >= 0
         self._height_limit = value
         # force recalculation of hashes

src/grizzly/common/status.py

@@ -149,7 +149,6 @@ def count(self, result_id: str, desc: str) -> tuple[int, bool]:
         Returns:
             Current count for given result_id.
         """
-        assert isinstance(result_id, str)
         self._count[result_id] += 1
         initial = False
         if result_id not in self._desc:
@@ -166,7 +165,6 @@ def get(self, result_id: str) -> ResultEntry:
         Returns:
             ResultEntry: Count and description.
         """
-        assert isinstance(result_id, str)
         return ResultEntry(
             result_id, self._count.get(result_id, 0), self._desc.get(result_id, None)
         )
@@ -345,7 +343,6 @@ def is_frequent(self, result_id: str) -> bool:
         Returns:
             True if limit has been exceeded otherwise False.
         """
-        assert isinstance(result_id, str)
         if self._limit < 1:
             return False
         if result_id in self._frequent:
@@ -381,7 +378,6 @@ def mark_frequent(self, result_id: str) -> None:
         Returns:
             None
         """
-        assert isinstance(result_id, str)
         if result_id not in self._frequent:
             self._frequent.add(result_id)
 
@@ -709,7 +705,6 @@ def record(self, name: str, duration: float) -> None:
             None
         """
         if self._enable_profiling:
-            assert isinstance(duration, (float, int))
             try:
                 self._profiles[name]["count"] += 1
                 if self._profiles[name]["max"] < duration:

src/grizzly/common/storage.py

@@ -386,7 +386,6 @@ def load(
         Returns:
             A TestCase.
         """
-        assert isinstance(path, Path)
         # load test case info
         entry_point, info = cls.load_meta(path, entry_point=entry_point)
         # create test case
@@ -545,7 +544,6 @@ def sanitize_path(path: str) -> str:
         Returns:
             Sanitized path.
         """
-        assert isinstance(path, str)
         # check for missing filename or path containing drive letter (Windows)
         if split(path)[-1] in ("", ".", "..") or ":" in path:
             raise ValueError(f"invalid path {path!r}")

src/grizzly/replay/replay.py

@@ -278,7 +278,6 @@ def run(
         if self._harness is None:
             server_map.set_redirect("grz_start", "grz_current_test", required=False)
         else:
-            assert isinstance(self._harness, bytes)
             assert self._harness, "harness must contain data"
 
             def harness_fn(_: str) -> bytes:  # pragma: no cover

src/grizzly/target/target.py

@@ -10,15 +10,15 @@
 from threading import Lock
 from typing import TYPE_CHECKING, final
 
-from sapphire import CertificateBundle
-
 from ..common.utils import grz_tmp
 from .assets import AssetManager
 
 if TYPE_CHECKING:
     from collections.abc import Iterable, Mapping
     from pathlib import Path
 
+    from sapphire import CertificateBundle
+
     from ..common.report import Report
     from .target_monitor import TargetMonitor
 
@@ -82,7 +82,6 @@ def __init__(
         assert log_limit >= 0
         assert memory_limit >= 0
         assert binary is not None and binary.is_file()
-        assert certs is None or isinstance(certs, CertificateBundle)
         self._asset_mgr = AssetManager(base_path=grz_tmp("target"))
         self._https = False
         self._lock = Lock()
@@ -122,7 +121,6 @@ def asset_mgr(self, asset_mgr: AssetManager) -> None:
             AssetManager.
         """
         self._asset_mgr.cleanup()
-        assert isinstance(asset_mgr, AssetManager)
         self._asset_mgr = asset_mgr
 
     @abstractmethod

src/loki/loki.py

@@ -146,7 +146,6 @@ def fuzz_data(self, data: bytes) -> bytes:
         Returns:
             Fuzzed data.
         """
-        assert isinstance(data, bytes)
         # open a temp file in memory for fuzzing
         with SpooledTemporaryFile(max_size=0x800000, mode="r+b") as tmp_fp:
             tmp_fp.write(data)