Skip to content

Add: bulk modify DN #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rimu-stack merged 2 commits into from
Jan 23, 2026
Merged

Add: bulk modify DN #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25d9c81
Add: Implement bulk modify DN endpoint and corresponding tests
Jan 23, 2026
ab36312
Refactor: Update endpoint path for bulk modify DN requests
Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/api/main/router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,18 @@ async def modify_dn(
return await request.handle_api(req.state.dishka_container)


@entry_router.post("/update_many/dn", error_map=error_map)
async def modify_dn_many(
requests: list[ModifyDNRequest],
req: Request,
) -> list[LDAPResult]:
"""LDAP MODIFY entry DN request."""
results = []
for request in requests:
results.append(await request.handle_api(req.state.dishka_container))
return results


@entry_router.delete("/delete", error_map=error_map)
async def delete(
request: DeleteRequest,
Expand Down
2 changes: 1 addition & 1 deletion interface
Open in desktop
Submodule interface updated from 95ed5e to f31962
78 changes: 78 additions & 0 deletions tests/test_api/test_main/test_router/test_modify_dn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,3 +540,81 @@ async def test_api_update_dn_invalid_new_superior(

assert isinstance(data, dict)
assert data.get("resultCode") == LDAPCodes.INVALID_DN_SYNTAX


@pytest.mark.asyncio
@pytest.mark.usefixtures("adding_test_user")
@pytest.mark.usefixtures("setup_session")
@pytest.mark.usefixtures("session")
async def test_api_modify_dn_many(http_client: AsyncClient) -> None:
"""Test API for bulk modify DN."""
entry_dn_1 = "cn=test,dc=md,dc=test"
entry_dn_2 = "cn=test2,dc=md,dc=test"

response = await http_client.post(
"/entry/add",
json={
"entry": entry_dn_2,
"password": None,
"attributes": [
{"type": "name", "vals": ["test2"]},
{"type": "cn", "vals": ["test2"]},
{"type": "objectClass", "vals": ["organization", "top"]},
],
},
)
assert response.json()["resultCode"] == LDAPCodes.SUCCESS

response = await http_client.post(
"/entry/update_many/dn",
json=[
{
"entry": entry_dn_1,
"newrdn": "cn=test",
"deleteoldrdn": True,
"new_superior": "ou=testModifyDn1,dc=md,dc=test",
},
{
"entry": entry_dn_2,
"newrdn": "cn=test2",
"deleteoldrdn": True,
"new_superior": "ou=testModifyDn1,dc=md,dc=test",
},
],
)

data = response.json()
assert all(
result.get("resultCode") == LDAPCodes.SUCCESS for result in data
)


@pytest.mark.asyncio
@pytest.mark.usefixtures("adding_test_user")
@pytest.mark.usefixtures("setup_session")
@pytest.mark.usefixtures("session")
async def test_api_modify_dn_many_with_error(http_client: AsyncClient) -> None:
"""Test bulk modify DN with one invalid entry."""
entry_dn = "cn=test,dc=md,dc=test"

response = await http_client.post(
"/entry/update_many/dn",
json=[
{
"entry": entry_dn,
"newrdn": "cn=test",
"deleteoldrdn": True,
"new_superior": "ou=testModifyDn1,dc=md,dc=test",
},
{
"entry": "cn=nonExistent,dc=md,dc=test",
"newrdn": "cn=nonExistent",
"deleteoldrdn": True,
"new_superior": "dc=md,dc=test",
},
],
)

data = response.json()
assert data[0].get("resultCode") == LDAPCodes.SUCCESS
assert data[1].get("resultCode") == LDAPCodes.NO_SUCH_OBJECT