Conversation
felixhekhorn
reviewed
Jun 8, 2026
| @@ -1,2 +1,2 @@ | |||
| __version__ = "0.0.0" | |||
Collaborator
There was a problem hiding this comment.
@evagroenendijk people are not running pre-commit 🙈 i.e.
Line 56 in 2c49156
felixhekhorn
requested changes
Jun 8, 2026
| lz4 = "^4.0.2" | ||
| numba = "^0.61.0" | ||
| # 0.60.0 is the last version compatible with 3.9 and 0.63 the first with 3.14 | ||
| numba = ">=0.60,<0.66" |
Collaborator
There was a problem hiding this comment.
- this + the Python line +
poetry.lockare the only real changes all others need to vanish - should we lift the lower version? it doesn't hurt, but we also don't need to care about 3.9 any longer
Author
There was a problem hiding this comment.
I agree that we should lift 3.9, just wanted to get some verification before I actually do so. No reason not to bump your environment to a newer python version.
felixhekhorn
requested changes
Jun 8, 2026
| ipython = "^8.0" | ||
| # benchmark | ||
| asv = "^0.4.2" | ||
| asv = "^0.6.5" |
Collaborator
There was a problem hiding this comment.
you are not sitting on top of master! see also 8b21535 -> maybe rebase (or given the bunch of unrelated changes restart?)
Author
There was a problem hiding this comment.
ahh oops, I thought I had rebased. I'll probably restart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bumped numba for python 3.14