Skip to content

Feature/gdas phase 1 configurations for radiance MHS data#2116

Open
jianjunj wants to merge 41 commits into
developfrom
feature/gdas_phase1_MHS_Metop-C_configure
Open

Feature/gdas phase 1 configurations for radiance MHS data#2116
jianjunj wants to merge 41 commits into
developfrom
feature/gdas_phase1_MHS_Metop-C_configure

Conversation

@jianjunj
Copy link
Copy Markdown
Contributor

@jianjunj jianjunj commented Apr 8, 2026

Description

Adds UFO/JCB YAML configurations for MHS on Metop-B, Metop-C, and NOAA-19, reproducing GSI clear-sky observational errors and QC. Obs error counts and data passing QC are verified to match GSI output (tested at 00z, Feb 19, 2024).

Companion PRs

Issues

#2115

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmsnowDA
  • C96_gcafs_cycled
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_ufsgsi_hybatmDA
  • C48_ufsenkf_atmDA
  • C96C48_hybatmDA

@jianjunj jianjunj requested a review from Copilot April 8, 2026 20:50
@jianjunj jianjunj self-assigned this Apr 8, 2026
@jianjunj jianjunj requested a review from ADCollard April 8, 2026 20:51
@jianjunj
Copy link
Copy Markdown
Contributor Author

jianjunj commented Apr 8, 2026

MHS_Metop-C
QCCount_Diff_Used_2024021900_radiance_mhs_metop-b
MHS_Meto-c
ObsErr_Difference_2024021900_radiance_mhs_metop-b

MHS_Meto-b.
QCCount_Diff_Used_2024021900_radiance_mhs_metop-c
MHS_Meto-b
ObsErr_Difference_2024021900_radiance_mhs_metop-c

MHS_N19 (channel 3 is passive in GSI)
QCCount_Diff_Used_2024021900_radiance_mhs_n19

MHS_N19(channel 3 is passive in GSI)
ObsErr_Difference_2024021900_radiance_mhs_n19

MHS observational errors and number of data passed QC in GSI are identical as those in UFO. Tested are done with GSI output at 00z, Feb 19, 2024.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the JCB-GDAS observation configuration catalog by adding clear-sky CRTM/UFO YAML templates and corresponding observation-chronicle metadata for MHS radiance instruments (Metop-B, Metop-C, and NOAA-19), aiming to reproduce GSI-like observation errors and QC behavior.

Changes:

  • Added new MHS radiance observation templates (radiance_mhs_metop-b, radiance_mhs_metop-c, radiance_mhs_n19) with detailed QC/error inflation logic.
  • Added/updated MHS observation-chronicle metadata files to provide channel configuration values used by the templates.
  • Updated the atmosphere obs list to include the new radiance types (currently commented out).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
parm/jcb-gdas/observations/atmosphere/radiance_mhs_n19.yaml.j2 New clear-sky MHS(N19) CRTM/UFO obs config with QC + error modeling.
parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-c.yaml.j2 New clear-sky MHS(Metop-C) CRTM/UFO obs config with QC + error modeling.
parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-b.yaml.j2 New clear-sky MHS(Metop-B) CRTM/UFO obs config with QC + error modeling.
parm/jcb-gdas/observation_chronicle/atmosphere/radiance_mhs_n19.yaml New MHS(N19) channel metadata (sim/active/bias/error/etc.).
parm/jcb-gdas/observation_chronicle/atmosphere/radiance_mhs_n18.yaml New MHS(N18) channel metadata.
parm/jcb-gdas/observation_chronicle/atmosphere/radiance_mhs_metop-c.yaml New MHS(Metop-C) channel metadata.
parm/jcb-gdas/observation_chronicle/atmosphere/radiance_mhs_metop-b.yaml New MHS(Metop-B) channel metadata.
parm/jcb-gdas/observation_chronicle/atmosphere/radiance_mhs_metop-a.yaml New MHS(Metop-A) channel metadata.
parm/atm/atm_obs_list.yaml.j2 Lists the new radiance types (commented out).

Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-b.yaml.j2
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-c.yaml.j2
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_n19.yaml.j2
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-b.yaml.j2
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-c.yaml.j2
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_n19.yaml.j2 Outdated
…n MHS templates

Agent-Logs-Url: https://github.com/NOAA-EMC/GDASApp/sessions/499257a3-8036-47ab-8c43-8b7bc6e3dfab

Co-authored-by: jianjunj <183659102+jianjunj@users.noreply.github.com>
jianjunj and others added 3 commits May 21, 2026 09:18
…l.j2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…l.j2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_n19.yaml.j2
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_n19.yaml.j2 Outdated
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-b.yaml.j2
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-b.yaml.j2 Outdated
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-c.yaml.j2
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-c.yaml.j2 Outdated
@jianjunj jianjunj force-pushed the feature/gdas_phase1_MHS_Metop-C_configure branch from af0de78 to a62ddef Compare May 21, 2026 20:15
@jianjunj jianjunj requested a review from Copilot May 21, 2026 20:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_n19.yaml.j2 Outdated
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-b.yaml.j2 Outdated
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-c.yaml.j2 Outdated
jianjunj and others added 3 commits May 21, 2026 13:33
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_n19.yaml.j2 Outdated
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_n19.yaml.j2
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-b.yaml.j2 Outdated
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-b.yaml.j2
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-c.yaml.j2 Outdated
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-c.yaml.j2
jianjunj and others added 4 commits May 21, 2026 13:43
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_n19.yaml.j2
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-b.yaml.j2
Comment thread parm/jcb-gdas/observations/atmosphere/radiance_mhs_metop-c.yaml.j2
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@jianjunj jianjunj changed the title Feature/gdas phase1 mhs metop c configure Feature/gdas phase 1 configurations for radiance MHS data May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants