code reivew: remove PERF comment, IS = definition

luke-kiernan · luke-kiernan · commit f49914bf1b05 · 2025-10-13T10:15:43.000-06:00
diff --git a/src/supplemental_attribute_associations.jl b/src/supplemental_attribute_associations.jl
@@ -487,7 +487,7 @@ function list_associated_supplemental_attribute_uuids(
     query = StringTemplates.render(
         _QUERY_LIST_ASSOCIATED_SUPPLEMENTAL_ATTRIBUTE_UUIDS_BY_TYPES;
         table_name = SUPPLEMENTAL_ATTRIBUTE_TABLE_NAME,
-        attribute_type_clause = attribute_type_clause, # PERF: swap order?
+        attribute_type_clause = attribute_type_clause,
         component_type_clause = component_type_clause,
     )
     table = Tables.columntable(_execute_cached(associations, query, params))
diff --git a/test/test_random_seed.jl b/test/test_random_seed.jl
@@ -1,4 +1,3 @@
-IS = InfrastructureSystems
 @testset "Random Seed" begin
     @test isa(IS.get_random_seed(), Int)
 end

Original file line number	Diff line number	Diff line change
`@@ -487,7 +487,7 @@ function list_associated_supplemental_attribute_uuids(`
`487`	`487`	`query = StringTemplates.render(`
`488`	`488`	`_QUERY_LIST_ASSOCIATED_SUPPLEMENTAL_ATTRIBUTE_UUIDS_BY_TYPES;`
`489`	`489`	`table_name = SUPPLEMENTAL_ATTRIBUTE_TABLE_NAME,`
`490`		`- attribute_type_clause = attribute_type_clause, # PERF: swap order?`
	`490`	`+ attribute_type_clause = attribute_type_clause,`
`491`	`491`	`component_type_clause = component_type_clause,`
`492`	`492`	`)`
`493`	`493`	`table = Tables.columntable(_execute_cached(associations, query, params))`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-IS = InfrastructureSystems`
`2`	`1`	`@testset "Random Seed" begin`
`3`	`2`	`@test isa(IS.get_random_seed(), Int)`
`4`	`3`	`end`