Logged "wrong bus type" errors

[luke-kiernan]

Due to changes in parsing in PowerSystems in PR #1398, systems that used to build okay now log errors: try build_system(PSISystems, "RTS_GMLC_DA_sys") in the psy5 branch. Solutions: surpress the warnings during the initial build, then fix the bus types afterward here in PowerSystemCaseBuilder.jl; or change the bus type back in PowerSystemsTestData.jl so there's no error.

Edit: this isn't just an inconvenience (meaningless logged errors). The system builds differently, with buses as PV where they used to be PQ, which breaks downstream test cases.

[luke-kiernan]

Here's all of the (category, system) pairs for which I'm getting "wrong bus type" errors.

MatpowerTestSystems, matpower_ACTIVSg10k_sys
MatpowerTestSystems, matpower_ACTIVSg2000_sys
MatpowerTestSystems, matpower_case14_sys
MatpowerTestSystems, matpower_case5_dc_sys
MatpowerTestSystems, matpower_frankenstein_00_sys
PSIDSystems, WECC 240 Bus
PSIDSystems, psid_4bus_multigen
PSISystems, AC_TWO_RTO_RTS_1Hr_sys
PSISystems, AC_TWO_RTO_RTS_5min_sys
PSISystems, HVDC_TWO_RTO_RTS_1Hr_sys
PSISystems, HVDC_TWO_RTO_RTS_5min_sys
PSISystems, MTHVDC_two_RTS_DA_sys_noForecast
PSISystems, RTS_GMLC_DA_sys
PSISystems, RTS_GMLC_DA_sys_noForecast
PSISystems, RTS_GMLC_RT_sys
PSISystems, RTS_GMLC_RT_sys_noForecast
PSISystems, modified_RTS_GMLC_DA_sys
PSISystems, modified_RTS_GMLC_DA_sys_noForecast
PSISystems, modified_RTS_GMLC_RT_sys
PSISystems, modified_RTS_GMLC_RT_sys_noForecast
PSISystems, modified_RTS_GMLC_realization_sys
PSITestSystems, c_sys5_all_components
PSITestSystems, c_sys5_hy
PSITestSystems, c_sys5_hy_ed
PSITestSystems, c_sys5_hy_ems_ed
PSITestSystems, c_sys5_hy_ems_uc
PSITestSystems, c_sys5_hy_uc
PSITestSystems, c_sys5_hybrid
PSITestSystems, c_sys5_re_only
PSITestSystems, test_RTS_GMLC_sys
PSITestSystems, test_RTS_GMLC_sys_with_hybrid
PSSEParsingTestSystems, PSSE 30 Test System
PSSEParsingTestSystems, psse_ACTIVSg2000_sys
PSSEParsingTestSystems, psse_RTS_GMLC_sys
PSSEParsingTestSystems, pti_frankenstein_00_2_sys
PSSEParsingTestSystems, pti_frankenstein_00_sys
PSSEParsingTestSystems, pti_frankenstein_20_sys
PSSEParsingTestSystems, pti_frankenstein_70_sys
PSSEParsingTestSystems, pti_modified_case14_sys
PSSEParsingTestSystems, pti_parser_test_a_sys
PSYTestSystems, dynamic_inverter_sys
PSYTestSystems, psse_3bus_SEXS_sys
PSYTestSystems, psse_3bus_gen_cls_sys
PSYTestSystems, psse_3bus_no_cls_sys
PSYTestSystems, tamu_ACTIVSg2000_sys
SPISystems, RTS_GMLC_5min with Static Outage Data
SPISystems, RTS_GMLC_5min with TimeSeries Outage Data
SPISystems, RTS_GMLC_Hourly with Static Outage Data
SPISystems, RTS_GMLC_Hourly with TimeSeries Outage Data

I was considering just tackling this issue quickly, by correcting the bus types in PowerSystemsTestData, but...there's 40+ of them. I'm thinking I'll fix the matpower_ACTIVSg10k_sys one now, and do the rest later.

Script used to generate the above list

using PowerSystems
using PowerSystemCaseBuilder
const PSY = PowerSystems
const PSB = PowerSystemCaseBuilder
using Logging
results = Vector{Any}()
for category in list_categories(SystemCatalog())
    # if this "list_systems" call returns no list, merge with main: that change happened
    # after the psy5 branch split off from main.
    for system in list_systems(SystemCatalog(), category)
        io = IOBuffer()
        bf = SimpleLogger(io, Logging.Error)
        @assert eof(io)
        with_logger(bf) do
            if category == PSIDTestSystems && system == "psid_psse_test_avr"
                build_system(category, system, avr_type = "AC1A_SAT")
            elseif category == PSIDTestSystems && system == "psid_psse_test_gen"
                build_system(category, system, gen_type = "GENCLS")
            elseif category == PSIDTestSystems && system == "psid_psse_test_pss"
                build_system(category, system, pss_type = "STAB1")
            elseif category == PSIDTestSystems && system == "psid_psse_test_tg"
                build_system(category, system, tg_type = "GAST")
            else
                build_system(category, system)
            end
        end
        seekstart(io)
        if !eof(io)
            println("errors for $category, $system")
            push!(results, (category, system, String(take!(io))))
        end
    end
end
for (category, system, msg) in results
    if occursin("active generators found at bus ACBus", msg)
        println("$category, $system")
    else
        println("\tDifferent error message for: $category, $system")
    end
end

edit: the above list includes both "active generators found at PQ bus" and "no active generators found at PV bus" types of errors. I believe the parser used to issue a warning (but leave the generator type as-is) in the first case and fix the generator type in the second case: since PR #1398, they're both logged errors. Of the two types, only the "no active generators found at PV" one is currently causing problems downstream: there's 14 systems with that type of error.

[rodrigomha]

@jd-lara I think we could tackle a bunch of the PSITestSystems directly in TestData by making sure that before adding the generators, we update the bus to PV, or changing to PQ if we remove generators.

[luke-kiernan]

Edit: this isn't just an inconvenience (meaningless logged errors). The system builds differently, with buses as PV where they used to be PQ, which breaks downstream test cases.

No longer accurate. PR #177 ("Add fix_bustypes option," currently unmerged) in PowerFlows.jl makes the test cases functional again. I'd still like to eliminate the logged errors, though: we use PSB in many other places than just PF.