-
Notifications
You must be signed in to change notification settings - Fork 25
feat: grpc remediation service #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the β¨ Finishing touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| org.opencontainers.image.revision: "{{.Env.GIT_COMMIT}}" | ||
| org.opencontainers.image.created: "{{.Env.BUILD_DATE}}" | ||
|
|
||
| - id: janitor-provider-aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of making one per CSP, can we make a single provider and switch based on env or something? This will result in an explosion of container images as we scale :)
| - name: janitor | ||
| version: "0.1.0" | ||
| condition: global.janitor.enabled | ||
| - name: janitor-provider-kwok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call this janitor-provider. Ideally for the helm chart if someone want to just run on AWS without writing any additional code, they should be able to provide the correct helm values, and it should just work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be maybe call this remeidation-providers/.../...
Summary
Type of Change
Component(s) Affected
Testing
Checklist