LED on by default

Author: AlCalzone

app.c

@@ -853,8 +853,8 @@ zaf_event_distributor_app_proprietary(event_nc_t *event)
       // Fade slowly to white
       LedEffectFade_t fade = {
         .color = cold_white,
-        .brightness = FADE_MIN_BRIGHTNESS,
-        .increasing = true,
+        .brightness = FADE_MAX_BRIGHTNESS,
+        .increasing = false,
         .ticksPerStep = 2,
         .stepSize = 1,
         .tickCounter = 0
@@ -870,11 +870,11 @@ zaf_event_distributor_app_proprietary(event_nc_t *event)
     case EVENT_APP_CONNECTED: {
       if (ledEffectDefault.type == LED_EFFECT_FADE) {
         // Stop the animation to indicate that we're connected
-        ledEffectDefault.effect.fade.stopAtMin = true;
+        ledEffectDefault.effect.fade.stopAtMax = true;
       } else {
-        // If we were not in fade mode, set the color to black
+        // If we were not in fade mode, set the color to white
         LedEffectSolid_t solid = {
-          .color = black,
+          .color = cold_white,
           .modified = true
         };
         ledEffectDefault = (LedEffect_t) {
@@ -990,10 +990,10 @@ zaf_event_distributor_app_proprietary(event_nc_t *event)
           // and update the color
           LedEffectFade_t fade = ledEffect->effect.fade;
 
-          if (fade.brightness <= FADE_DIM_THRESHOLD && fade.stopAtMin) {
+          if (fade.brightness >= FADE_BRIGHT_THRESHOLD && fade.stopAtMax) {
             // Switch to solid mode
             LedEffectSolid_t solid = {
-              .color = black,
+              .color = fade.color,
               .modified = true
             };
             *ledEffect = (LedEffect_t) {
@@ -1235,8 +1235,8 @@ ApplicationInit(
     };
     set_color_buffer(color);
   } else {
-    // Default to off
-    set_color_buffer(black);
+    // Default to on
+    set_color_buffer(cold_white);
   }
 
   // Try to restore configuration settings from NVM

app.h

@@ -283,7 +283,7 @@ typedef struct LedEffectSolid {
 #define FADE_MAX_BRIGHTNESS 0xff
 #define FADE_MIN_BRIGHTNESS 25 // Don't turn off while fading, looks odd
 // Used to switch from fade to solid when the LED is bright enough
-#define FADE_DIM_THRESHOLD 40
+#define FADE_BRIGHT_THRESHOLD 0xe0
 
 typedef struct LedEffectFade {
   rgb_t color;
@@ -292,7 +292,7 @@ typedef struct LedEffectFade {
   uint8_t stepSize;
   uint8_t tickCounter;
   bool increasing;
-  bool stopAtMin;
+  bool stopAtMax;
 } LedEffectFade_t;
 
 typedef struct LedEffectBlink {