Fix (web): Fix bugs in some pages

Co-authored-by: Leonard Jonathan Oh <[email protected]>

Author: Rushaway

web/autocomplete.php

@@ -13,8 +13,8 @@
 	error('Database class does not exist.  Please check your config.php file for DB_TYPE');
 }
 
-$game = valid_request($_GET['game']);
-$search = valid_request($_POST['value']);
+$game = valid_request($_GET['game'] ?? '');
+$search = valid_request($_POST['value'] ?? '');
 
 $game_escaped = $db->escape($game);
 $search_escaped = $db->escape($search);

web/pages/actioninfo.php

@@ -172,7 +172,8 @@
 				hlstats_Events_PlayerPlayerActions.actionId = hlstats_Actions.id AND
 				hlstats_Players.hideranking = '0'
 			GROUP BY
-				hlstats_Events_PlayerPlayerActions.playerId
+				hlstats_Events_PlayerPlayerActions.playerId,
+				hlstats_Actions.reward_player
 			ORDER BY
 				$table->sort $table->sortorder,
 				$table->sort2 $table->sortorder
@@ -214,7 +215,8 @@
 				hlstats_Events_TeamBonuses.actionId = hlstats_Actions.id AND
 				hlstats_Players.hideranking = '0'
 			GROUP BY
-				hlstats_Events_TeamBonuses.playerId
+				hlstats_Events_TeamBonuses.playerId,
+				hlstats_Actions.reward_player
 			ORDER BY
 				$table->sort $table->sortorder,
 				$table->sort2 $table->sortorder

web/pages/ingame/actioninfo.php

@@ -44,15 +44,15 @@
 
 	// Addon created by Rufus ([email protected])
 
-	$action = valid_request($_GET['action'], true) or error('No action ID specified.');
+	$action = valid_request($_GET['action'], true) or error('No action code specified.');
 
 	$db->query("
 		SELECT
 			description
 		FROM
 			hlstats_Actions
 		WHERE
-			id='$action_id'
+			code='$action'
 			AND game='$game'
 	");
 

web/pages/teamspeak.php

@@ -24,7 +24,7 @@ function show($tpl, $array)
 
 
 
-  if (function_exists(fopen))
+  if (function_exists('fopen'))
   {
     $db->query("SELECT addr, queryPort, UDPPort FROM hlstats_Servers_VoiceComm WHERE serverId=$tsId");
     $s = $db->fetch_array();
@@ -252,4 +252,4 @@ function show($tpl, $array)
     echo "Error, function fopen not found";
   }
 
-?>
+?>

web/pages/ventrilo.php

@@ -137,9 +137,9 @@ function show($tpl, $array)
 {
     $template = PAGE_PATH."/templates/ventrilo/".$tpl;
 
-    if($fp = @fopen($template.".".html, "r"))
+    if($fp = @fopen("$template.html", "r"))
 	{
-		$tpl = @fread($fp, filesize($template.".".html));
+		$tpl = @fread($fp, filesize("$template.html"));
 	}
 	else
 	{
@@ -216,4 +216,4 @@ function show($tpl, $array)
 
     echo $outp_str;
 
-?>
+?>

web/pages/ventrilostatus.php

@@ -197,11 +197,11 @@ class CVentriloStatus
 
 	var	$m_channelcount;		// Number of channels as specified by the server.
 	var	$m_channelfields;		// Channel field names.
-	var	$m_channellist;			// Array of CVentriloChannel's.
+	var	$m_channellist = [];	// Array of CVentriloChannel's.
 
 	var	$m_clientcount;			// Number of clients as specified by the server.
 	var	$m_clientfields;		// Client field names.
-	var $m_clientlist;			// Array of CVentriloClient's.
+	var $m_clientlist = []; 	// Array of CVentriloClient's.
 
 	function Parse( $str )
 	{
@@ -898,4 +898,4 @@ function __construct( $packet )
 	}
 }
 /* end of VentResponsePacket class */
-?>
+?>

web/status.php

@@ -315,15 +315,17 @@
 	if ($map_image == 1)
 	{
 		$mapimg = getImage("/games/{$game}/maps/{$server_data['act_map']}");
-		if (!file_exists($mapimg['path'])) {
+		if ($mapimg && !file_exists($mapimg['path'])) {
 			$mapimg = getImage("/games/{$game}/maps/default");
 			if (!file_exists($mapimg['path'])) {
 				$mapimg = getImage("/nomap");
 			}
+		} else {
+			$mapimg = getImage("/nomap");
 		}
 
 		echo '<tr><td align="center" colspan="2">';
-		echo '<a target="_blank" href="'.$g_options['scriptbase'].'/hlstats.php?mode=mapinfo&amp;map='.$server_data['act_map'].'&amp;game='.$game.'"><img src="'.$mapimg['url'].'" style="width:'.$width.'px;border:0px" alt="'.$server_data['act_map'].'" title="'.$server_data['act_map'].'" /></a>'; 
+		echo '<a target="_blank" href="'.$g_options['scriptbase'].'/hlstats.php?mode=mapinfo&amp;map='.$server_data['act_map'].'&amp;game='.$game.'"><img src="' . ($mapimg['url'] ?? '') . '" style="width:'.$width.'px;border:0px" alt="'.$server_data['act_map'].'" title="'.$server_data['act_map'].'" /></a>'; 
 		echo '</td></tr>';
 	}
 

web/trend_graph.php

@@ -64,10 +64,7 @@
 		$color = hex2rgb(valid_request($_GET['color'], false));
 	}
 
-	if (isset($_GET['player'])) {
-		$player = (int)$_GET['player'];
-	}
-
+	$player = valid_request(intval($_GET['player'] ?? ''), true);
 	if (!$player) {
 		exit();
 	}