nixos/pam: fix infinite recursion (#460035)

LordGrimmauld · web-flow · commit ffd468f28a01 · 2025-11-09T17:28:42.000Z
diff --git a/nixos/modules/security/pam.nix b/nixos/modules/security/pam.nix
@@ -2312,8 +2312,7 @@ in
     environment.etc = lib.mapAttrs' makePAMService enabledServices;
 
     systemd =
-      lib.optionalAttrs
-        (lib.any (service: service.updateWtmp) (lib.attrValues config.security.pam.services))
+      lib.mkIf (lib.any (service: service.updateWtmp) (lib.attrValues config.security.pam.services))
         {
           tmpfiles.packages = [ pkgs.util-linux.lastlog ]; # /lib/tmpfiles.d/lastlog2-tmpfiles.conf
           services.lastlog2-import = {

Original file line number	Diff line number	Diff line change
`@@ -2312,8 +2312,7 @@ in`
`2312`	`2312`	`environment.etc = lib.mapAttrs' makePAMService enabledServices;`
`2313`	`2313`
`2314`	`2314`	`systemd =`
`2315`		`- lib.optionalAttrs`
`2316`		`- (lib.any (service: service.updateWtmp) (lib.attrValues config.security.pam.services))`
	`2315`	`+ lib.mkIf (lib.any (service: service.updateWtmp) (lib.attrValues config.security.pam.services))`
`2317`	`2316`	`{`
`2318`	`2317`	`tmpfiles.packages = [ pkgs.util-linux.lastlog ]; # /lib/tmpfiles.d/lastlog2-tmpfiles.conf`
`2319`	`2318`	`services.lastlog2-import = {`