notmuch: move the vim plugin to another output #353500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wondered why my neovim was slow. Turned out notmuch.vim loading took > 500ms to load (ruby and all). And I dont even use it ! I suspect the plugin could be improved to lazyload more stuff but I think it's ok to have the vim plugin installer be a user decision as well. I moved it to a new "vim" output : you can install the plugin via "notmuch.vim"
teto
force-pushed
the
teto/notmuch.vim
branch
from
5929a99 to
0082fde
Compare
github-actions
bot
added
6.topic: nixos
nix-owners
bot
requested review from
GaetanLepage,
PerchunPak,
figsoda,
khaneliman,
manveru,
mrcjkb and
rvolosatovs
mrcjkb
approved these changes
Nov 19, 2024
wegank
added
the
12.approvals: 1
Contributor
|
khaneliman
approved these changes
Nov 19, 2024
Member
Author
|
ccing maintainers @flokli @puckipedia |
wegank
added
12.approvals: 2
ofborg
bot
added
10.rebuild-darwin: 11-100
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wondered why my neovim was slow. Turned out notmuch.vim loading took > 500ms to load (ruby and all). And I dont even use it ! I suspect the plugin could be improved to lazyload more stuff but I think it's ok to have the vim plugin installer be a user decision as well. I moved it to a new "vim" output : you can install the plugin via "notmuch.vim"
since it might require a transition phase for notmuch users, I mark it as draft just so that users with the same issue can find this.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.