Skip to content

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Nov 10, 2025

migrate liquidwar to by-name

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@guylamar2006 guylamar2006 requested a review from Copilot November 10, 2025 19:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the liquidwar and liquidwar5 packages from the legacy pkgs/games/liquidwar/ directory structure to the new pkgs/by-name/li/ organizational structure, which is the modern convention for Nix package organization.

Key changes:

  • Removes old package references from all-packages.nix
  • Creates new package definitions in pkgs/by-name/li/liquidwar/ and pkgs/by-name/li/liquidwar5/
  • Updates the liquidwar package to explicitly use guile_2_0 instead of the generic guile parameter

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
pkgs/top-level/all-packages.nix Removes old liquidwar and liquidwar5 package references
pkgs/by-name/li/liquidwar5/package.nix Creates new package definition for liquidwar5 in the by-name structure
pkgs/by-name/li/liquidwar/package.nix Creates new package definition for liquidwar (version 6) with explicit guile_2_0 dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@guylamar2006
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 460429
Commit: 5a1432f619a0314fcdc762d9a0fe312d98deca7b (subsequent changes)
Merge: e3338afff20f3eaf2be8070401e891f2c4739fa0

Logs: https://github.com/guylamar2006/nixpkgs-review-gha/actions/runs/19242879240


x86_64-linux

No rebuilds


aarch64-linux

No rebuilds


x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Nov 10, 2025
Copy link
Contributor

@zimward zimward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff seems fine

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants