Dynamic shadows crashes (Linux)

[Placo]

Quite recently I acquired a RX9070 XT and I have been testing ray traced stuff since that's my first RT capable video card.
I've been playing ad_tears (once again) with dynamic shadows turned on (set at low) but vkQuake crashes on quickloads quite frequently.
It is quite hard to reproduce as it will not always crash consistently.

When I say crash, I mean the screen freezes with looping audio and it usually crashes to desktop after 10/15 seconds but sometimes the kernel don't even recover and I am forced to hit the reset button.

Here's what I could see after a crash when launching vkQuake in a terminal:

Loading game from /path/to/Quake/AD180/quick.sav...

radv/amdgpu: The CS has been cancelled because the context is lost. This context is guilty of a hard recovery.
radv: GPUVM fault detected at address 0x80014b477000.
GCVM_L2_PROTECTION_FAULT_STATUS: 0x301031
	 CLIENT_ID: (TCP) 0x8
	 MORE_FAULTS: 1
	 WALKER_ERROR: 0
	 PERMISSION_FAULTS: 3
	 MAPPING_ERROR: 0
	 RW: 0

ERROR-OUT BEGIN

vkquake: ../Quake/host.c:1154: Host_Shutdown: Assertion `!Tasks_IsWorker ()' failed.
Abandon (core dumped)

I figure it is the video drivers that crash?

It seems I get crashes more consistently when quickloading a save made near the top of the level (near the widowmaker shotgun when the pillar is raised.

I have never been able to have a crash when loading the map for the first time. I have to load the game, play for a little bit (sometimes just a couple of seconds) then quickload.

Since I saw Novum's issue here about FTE particles I have tried turning them off but I still get the crashes.

I've then turned off dynamic shadows and I don't seem to get any crash (I will test that some more)

I don't think it's an hardware issue since I've been playing other stuff without problem (Cyberpunk 77 for example).
I am on Linux Mint 22.3 Cinnamon with 6.17 kernel (I have had the same crashes in 6.14)
Mesa drivers are 26.0 (had the same crashes with 25.3)
vkquake is self-built from sources at revision dabad40

[Placo]

I could finish the level without any crash with dynamic shadows turned off.
Then I turned them back on and could not get any crash in the subterranean sanctum of tears boss fight area, even when abusing the quickload key.
I restarted the map and got a crash as soon as I got outside (not on a load game).
It seems it is the scenes with a sky that can cause the issue...

[Novum]

Impossible to tell if this isn't a bug in RADV, but thanks for the report. Can you maybe try the commit before the refit one?

[Placo]

I went ahead and tried your fix 107a1d7
It seems to have fixed the issue! I've played through Tears of the False God (again :D) for more than an hour and did not have a crash.
Beforehand I had tried to play my old vkquake version just to make sure it crashed (and I had not fixed something in my system somehow since my last post) and yes it crashed.
So yeah you've fixed it, thanks a bunch!

If you want me to I can test revision 1ac9214 as you suggested (for science)

[Novum]

This is weird because the scratch is pretty big (16MB). We shouldn't be hitting that limit with just Quake triangle counts. I need to check if there is a bug that we can't use the whole scratch for some reason.
Or RADV is really that inefficient with scratch and requires a lot more than NVIDIA.

If this fixed it, no need to check 1ac9214. Would be more helpful to get some more playtime with the new commit so we are sure it actually fixed it.

[Placo]

I spent the night playing through several levels/mods and did not get a single RADV related crash (I did get an unrelated crash in sv_phys.c that I still need to report here).

I will play some more and let you know.

[Placo]

I played a lot of different maps and mods since and did not get any crash.
I did also get a lot of playtime with your fixes/dynamic allocations around a480b50 and it seems to be working well as well.

Do tell me if you want me to test anything AMD drivers related.

[Novum]

Any dynamic light casts shadows.

[Novum]

No.

[bubbleguuum]

K. Posts removed. Sorry for the bother.

[Novum]

As for the rocket/lava llights being weird, this fixes it e81548f

[Novum]

This should be fixed then.