[FIX] account_statement_import_sheet_file: Bugs with amount_type selection

Author: feg-adhoc

account_statement_import_sheet_file/models/account_statement_import_sheet_mapping.py

@@ -233,6 +233,13 @@ def _check_columns(self):
             if mapping.offset_column < 0:
                 raise ValidationError(_("Offsets cannot be negative"))
 
+    @api.onchange("amount_type")
+    def _clear_amount_columns(self):
+        self.amount_column = False
+        self.debit_credit_column = False
+        self.amount_debit_column = False
+        self.amount_credit_column = False
+
     def _get_float_separators(self):
         self.ensure_one()
         separators = {

account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py

@@ -314,11 +314,14 @@ def _decimal(column_name, values):
                         mapping,
                     )
 
-            amount = _decimal("amount_column", values)
-            if not amount:
+            if mapping.amount_type == "distinct_credit_debit":
                 amount = abs(_decimal("amount_debit_column", values) or 0)
-            if not amount:
-                amount = -abs(_decimal("amount_credit_column", values) or 0)
+                if not amount:
+                    amount = -abs(_decimal("amount_credit_column", values) or 0)
+            elif mapping.amount_type == "simple_value":
+                amount = _decimal("amount_column", values)
+            elif mapping.amount_type == "absolute_value":
+                amount = abs(_decimal("debit_credit_column", values) or 0)
 
             balance = (
                 self._get_values_from_column(values, columns, "balance_column")

account_statement_import_sheet_file/views/account_statement_import_sheet_mapping.xml

@@ -78,8 +78,8 @@
                             <field name="amount_type" />
                             <field
                                 name="amount_column"
-                                invisible="amount_type == 'distinct_credit_debit'"
-                                required="amount_type != 'distinct_credit_debit'"
+                                invisible="amount_type != 'simple_value'"
+                                required="amount_type == 'simple_value'"
                             />
 
                             <field
@@ -92,15 +92,15 @@
                                 invisible="amount_type != 'distinct_credit_debit'"
                                 required="amount_type == 'distinct_credit_debit'"
                             />
-                            <field name="amount_inverse_sign" />
-                            <field name="balance_column" />
-                            <field name="original_currency_column" />
-                            <field name="original_amount_column" />
                             <field
                                 name="debit_credit_column"
                                 invisible="amount_type != 'absolute_value'"
                                 required="amount_type == 'absolute_value'"
                             />
+                            <field name="amount_inverse_sign" />
+                            <field name="balance_column" />
+                            <field name="original_currency_column" />
+                            <field name="original_amount_column" />
                             <field name="transaction_id_column" />
                             <field name="description_column" />
                             <field name="notes_column" />