[FIX] pre-commit & unit tests errors

Author: Kiplangatdan

account_statement_import_online_wise/models/online_bank_statement_provider_wise.py

@@ -50,12 +50,12 @@ def values_wise_profile(self):
         except BaseException:
             _logger.warning("Unable to get profiles", exc_info=True)
             return []
+
         return list(
             map(
                 lambda entry: (
                     str(entry["id"]),
-                    "%s %s (personal)"
-                    % (
+                    "{} {} (personal)".format(
                         entry["details"]["firstName"],
                         entry["details"]["lastName"],
                     )
@@ -253,7 +253,7 @@ def _wise_transaction_to_lines(self, transaction):
                     "amount": str(fees_value),
                     "date": date,
                     "partner_name": "Wise",
-                    "unique_import_id": "%s-FEE" % unique_import_id,
+                    "unique_import_id": f"{unique_import_id}-FEE",
                     "payment_ref": _("Transaction fee for %s") % reference_number,
                 }
             ]
@@ -281,7 +281,9 @@ def _wise_retrieve(self, url, api_key, private_key=None):
             if e.code != 403 or e.headers.get("X-2FA-Approval-Result") != "REJECTED":
                 raise e
             if not private_key:
-                raise UserError(_("Strong Customer Authentication is not configured"))
+                raise UserError(
+                    _("Strong Customer Authentication is not configured")
+                ) from e
             one_time_token = e.headers["X-2FA-Approval"]
             signature = private_key.sign(
                 one_time_token.encode(),
@@ -306,7 +308,7 @@ def _wise_urlopen(self, url, api_key, ott=None, signature=None):
         if not api_key:
             raise UserError(_("No API key specified!"))
         request = urllib.request.Request(url)
-        request.add_header("Authorization", "Bearer %s" % api_key)
+        request.add_header("Authorization", f"Bearer {api_key}")
         if ott and signature:
             request.add_header("X-2FA-Approval", ott)
             request.add_header("X-Signature", signature)
@@ -335,9 +337,9 @@ def _onchange_wise_certificate_private_key(self):
                 )
                 .decode()
             )
-        except BaseException:
+        except BaseException as exception:
             _logger.warning("Unable to parse key", exc_info=True)
-            raise UserError(_("Unable to parse key"))
+            raise UserError(_("Unable to parse key")) from exception
 
     def _wise_generate_key(self):
         self.ensure_one()

account_statement_import_online_wise/tests/test_account_statement_import_online_wise.py

@@ -11,8 +11,7 @@
 from dateutil.relativedelta import relativedelta
 
 from odoo import fields
-from odoo.tests import common
-from odoo.tests import Form
+from odoo.tests import Form, common
 
 _module_ns = "odoo.addons.account_statement_import_online_wise"
 _provider_class = (
@@ -126,7 +125,7 @@ def test_values_wise_profile(self):
             return_value=mocked_response,
         ):
             values_wise_profile = self.OnlineBankStatementProvider.with_context(
-                {"api_base": "https://example.com", "api_key": "dummy"}
+                api_base="https://example.com", api_key="dummy"
             ).values_wise_profile()
         self.assertEqual(
             values_wise_profile,
@@ -138,18 +137,18 @@ def test_values_wise_profile(self):
 
     def test_values_wise_profile_no_key(self):
         values_wise_profile = self.OnlineBankStatementProvider.with_context(
-            {"api_base": "https://example.com"}
+            api_base="https://example.com"
         ).values_wise_profile()
         self.assertEqual(values_wise_profile, [])
 
     def test_values_wise_profile_error(self):
         values_wise_profile = []
         with mock.patch(
             _provider_class + "._wise_retrieve",
-            side_effect=lambda: Exception(),
+            side_effect=Exception("Test error"),
         ):
             values_wise_profile = self.OnlineBankStatementProvider.with_context(
-                {"api_base": "https://example.com", "api_key": "dummy"}
+                api_base="https://example.com", api_key="dummy"
             ).values_wise_profile()
         self.assertEqual(values_wise_profile, [])
 
@@ -764,8 +763,6 @@ def test_transaction_parse_8(self):
                 "name": "Converted 7.93 USD to 6.93 EUR",
                 "payment_ref": "BALANCE-123456789: Converted 7.93 USD to 6.93 EUR",
                 "amount": "-7.88",
-                "amount_currency": "-6.93",
-                "foreign_currency_id": self.currency_eur.id,
                 "unique_import_id": "DEBIT-BALANCE-123456789-946684800",
             },
         )