Skip to content

Commit b5db8c9

Browse files
committed
[IMP] account_statement_import_camt: ignore details for negative transactions
1 parent decb48b commit b5db8c9

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

account_statement_import_camt/models/account_journal.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class AccountJournal(models.Model):
88
_inherit = "account.journal"
99

1010
ignore_camt_transaction_details = fields.Boolean(
11-
string="Ignore CAMT transaction details"
11+
string="Ignore CAMT transaction details for negative amounts",
1212
)
1313

1414
def _get_bank_statements_available_import_formats(self):

account_statement_import_camt/models/account_statement_import_camt_parser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ def parse_entry(self, ns, node):
296296
journal = self.env["account.journal"].browse(
297297
self.env.context.get("journal_id")
298298
)
299-
if journal.ignore_camt_transaction_details:
299+
if journal.ignore_camt_transaction_details and amount < 0:
300300
transaction["narration"] = transaction["narration"] or None
301301
yield transaction
302302
return

account_statement_import_camt/tests/test_import_bank_statement.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,8 @@ def test_statement_import(self):
186186
for line in statement_lines
187187
)
188188
)
189+
for line in statement_lines:
190+
self.assertTrue(line.partner_id != False)
189191

190192
def test_statement_import_without_transaction_details(self):
191193
"""Test correct creation of single statement."""
@@ -205,6 +207,11 @@ def test_statement_import_without_transaction_details(self):
205207
)
206208
statement_lines = bank_st_record.line_ids
207209
self.assertEqual(len(statement_lines), 3)
210+
for line in statement_lines:
211+
if line.amount < 0:
212+
self.assertFalse(line.partner_id)
213+
else:
214+
self.assertTrue(line.partner_id != False)
208215

209216
def test_zip_import(self):
210217
"""Test import of multiple statements from zip file."""

0 commit comments

Comments
 (0)