base_rest_pydantic 19.0: Manifest file invalid

[mkanderson]

Module

base_rest_pydantic

Describe the bug

manifest.py contains duplicate "installable" keys, one of them residing inside "external_dependencies".

rest-framework/base_rest_pydantic/__manifest__.py

Line 17 in 7d9cb8e

'installable': False,

To Reproduce

Install

Steps to reproduce the behavior:

1. Parse/validate the manifest.py file using any parsing tool that expects standard Odoo manifest schema.

Expected behavior
Manifest should conform to schema

Additional context
Add any other context about the problem here. (e.g. OS, Python version, ...)

[sbidoul]

This simply means this module is not migrated yet. See README.md.

[mkanderson]

Thanks for the quick reply.

manifest.py contains duplicate "installable" keys, one of them residing inside "external_dependencies".

    "external_dependencies": {
        "python": [
            "pydantic>=2.0.0",
        ],
    'installable': False,
},
    'installable': False,
}

The duplicate installable key as a child of external_dependencies is certainly not intended, or? This confuses our dependency-graph tooling.

[sbidoul]

Ah, yes, that's a syntax error indeed, sorry. Likely introduced when creating the 19.0 branch. If it causes problem to your tooling, feel free to file a PR to fix that.