[FIX] mass_mailing_partner: control readonly field

Author: kobros-tech

mass_mailing_partner/README.rst

@@ -102,6 +102,10 @@ Contributors
 
     * Jairo Llopis
 
+* `Kencove <https://kencove.com>`_:
+
+    * Mohamed Alkobrosli
+
 Other credits
 ~~~~~~~~~~~~~
 

mass_mailing_partner/models/mailing_contact.py

@@ -42,16 +42,19 @@ def _check_partner_id_list_ids(self):
                         + ": %s" % contact.partner_id.display_name
                     )
 
+    def update_fields_based_on_partner(self):
+        for rec in self.filtered("partner_id"):
+            rec.name = rec.partner_id.name
+            rec.email = rec.partner_id.email
+            rec.title_id = rec.partner_id.title
+            rec.company_name = (
+                rec.partner_id.company_id.name or rec.partner_id.company_name
+            )
+            rec.country_id = rec.partner_id.country_id
+
     @api.onchange("partner_id")
     def _onchange_partner_mass_mailing_partner(self):
-        if self.partner_id:
-            self.name = self.partner_id.name
-            self.email = self.partner_id.email
-            self.title_id = self.partner_id.title
-            self.company_name = (
-                self.partner_id.company_id.name or self.partner_id.company_name
-            )
-            self.country_id = self.partner_id.country_id
+        self.update_fields_based_on_partner()
 
     def _overwrite_partner(self, vals, creating=False):
         """Overwrite partner and update contact data if needed."""
@@ -63,7 +66,7 @@ def _overwrite_partner(self, vals, creating=False):
         if "partner_id" not in vals:
             _self._set_partner()
         if creating or prev_partner != _self.partner_id:
-            _self._onchange_partner_mass_mailing_partner()
+            _self.update_fields_based_on_partner()
 
     @api.model_create_multi
     def create(self, vals_list):
@@ -75,7 +78,7 @@ def create(self, vals_list):
     def write(self, vals):
         result = super().write(vals)
         for contact in self:
-            contact._overwrite_partner(vals)
+            contact._overwrite_partner(vals, False)
         return result
 
     def _get_categories(self):

mass_mailing_partner/readme/CONTRIBUTORS.rst

@@ -20,3 +20,7 @@
 * `Moduon <https://www.moduon.team>`_:
 
     * Jairo Llopis
+
+* `Kencove <https://kencove.com>`_:
+
+    * Mohamed Alkobrosli

mass_mailing_partner/static/description/index.html

@@ -454,6 +454,13 @@ <h1>Contributors</h1>
 </ul>
 </blockquote>
 </li>
+<li><p class="first"><a class="reference external" href="https://kencove.com">Kencove</a>:</p>
+<blockquote>
+<ul class="simple">
+<li>Mohamed Alkobrosli</li>
+</ul>
+</blockquote>
+</li>
 </ul>
 </div>
 <div class="section" id="other-credits">

mass_mailing_partner/tests/test_mail_mass_mailing_contact.py

@@ -106,7 +106,7 @@ def test_onchange_partner(self):
         }
         partner = self.create_partner(partner_vals)
         contact.partner_id = partner
-        contact._onchange_partner_mass_mailing_partner()
+        contact.update_fields_based_on_partner()
         self.check_mailing_contact_partner(contact)
 
     def test_partners_merge(self):

mass_mailing_partner/views/mailing_contact_view.xml

@@ -30,31 +30,37 @@
                 <attribute
                     name="attrs"
                 >{'readonly': [('partner_id', '!=', False)]}</attribute>
+                <attribute name="force_save">1</attribute>
             </field>
             <field name="email" position="attributes">
                 <attribute
                     name="attrs"
-                >{'readonly': [('partner_id', '!=', False)]}</attribute>
+                >{'readonly': [('partner_id', '!=', False), ('email', '!=', False)]}</attribute>
+                <attribute name="force_save">1</attribute>
             </field>
             <field name="name" position="attributes">
                 <attribute
                     name="attrs"
                 >{'readonly': [('partner_id', '!=', False)]}</attribute>
+                <attribute name="force_save">1</attribute>
             </field>
             <field name="company_name" position="attributes">
                 <attribute
                     name="attrs"
                 >{'readonly': [('partner_id', '!=', False)]}</attribute>
+                <attribute name="force_save">1</attribute>
             </field>
             <field name="country_id" position="attributes">
                 <attribute
                     name="attrs"
                 >{'readonly': [('partner_id', '!=', False)]}</attribute>
+                <attribute name="force_save">1</attribute>
             </field>
             <field name="tag_ids" position="attributes">
                 <attribute
                     name="attrs"
                 >{'readonly': [('partner_id', '!=', False)]}</attribute>
+                <attribute name="force_save">1</attribute>
             </field>
         </field>
     </record>