-
-
Notifications
You must be signed in to change notification settings - Fork 697
[17.0] mail_gateway: Migration to 17.0 #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WIP for test workflows of mail_gateway migration in OCA#1614
40b0825 to
c5ea53f
Compare
WIP for test workflows of mail_gateway migration in OCA#1614
2960391 to
4116f81
Compare
WIP for test workflows of mail_gateway migration in OCA#1614
daf2808 to
3c05c03
Compare
f22ff5b to
a5cfe3a
Compare
Currently translated at 100.0% (85 of 85 strings) Translation: social-16.0/social-16.0-mail_gateway Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_gateway/it/
Other OCA modules extending the composer add m2m fields with fixed relations. To avoid a glue module we try for the moment to add those manually. TT51108
Currently translated at 81.2% (113 of 139 strings) Translation: social-16.0/social-16.0-mail_gateway Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_gateway/it/
Currently translated at 10.7% (15 of 139 strings) Translation: social-16.0/social-16.0-mail_gateway Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_gateway/es/
…ated to the current user - Use OdooBot for webhooks instead of the current user, following the same logic as Odoo. - Avoid automatically adding the current user as a member of a new gateway to prevent notifications for all messages. This is now an explicit configuration.
a5cfe3a to
993561c
Compare
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, just a minor changes.
I tested the function locally with mail_gateway_whatsapp, and it worked fine.
| <record id="mail_channel_gateway_rule" model="ir.rule"> | ||
| <field name="name">Mail.channel: access gateway</field> | ||
| <field name="model_id" ref="mail.model_mail_channel" /> | ||
| <record id="discuss_channel_gateway_rule" model="ir.rule"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really necessary to change the xml_id? This change might require a script for OpenUpgrade, or did I miss something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, is a noupdate="0" record in this case, so the old one will be dropped.
| def create_partner(self): | ||
| partner = self.env["res.partner"].create(self._get_partner_vals()) | ||
| self._merge_partner(partner) | ||
| return partner.get_formview_action() | ||
|
|
||
| def _get_partner_vals(self): | ||
| return { | ||
| "name": self.guest_id.name, | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do you get them from? In telegram for instance you don't have such data. Maybe in whatsapp it could be inferred from the token...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but I mean that should be dealt in mail_gateway_whatsapp, as other gateways might not have that info at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but I mean that should be dealt in mail_gateway_whatsapp, as other gateways might not have that info at all
Ahh, ok, sorry! But I agree, this information is specific to WhatsApp.
a5af4b4 to
4850108
Compare
4850108 to
56e5c2d
Compare
|
please @carlos-lopez-tecnativa review this again |
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. LGTM.
|
/ocabot migration mail_gateway |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 8ebc792. Thanks a lot for contributing to OCA. ❤️ |
WIP for test workflows of mail_gateway migration in OCA#1614


What's been done:
cc @Tecnativa TT50728
please review @carlos-lopez-tecnativa @CarlosRoca13