-
Notifications
You must be signed in to change notification settings - Fork 0
Final Polars Fix #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final Polars Fix #54
Conversation
WalkthroughBumps app/version identifiers from 0.9.13 to 0.9.14 in workflow and settings. Adds early multiprocessing start-method enforcement to "spawn" in app.py before other imports. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant App as app.py
participant MP as multiprocessing
participant Modules as Other Modules
User->>App: Launch application
rect rgb(230, 245, 255)
note right of App: Startup initialization (new)
App->>MP: get_start_method()
alt method != "spawn"
App->>MP: set_start_method("spawn", force=True)
note over App,MP: Ensure safe process start model
else already "spawn"
App-->>MP: No change
end
end
App->>Modules: Import and initialize dependencies
User-->>App: Interact with running app
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app.py (1)
1-5: Nit: clarify OS scope and fix comment typo (optional).
Make intent explicit (non‑Windows) and tweak wording.Apply:
-# Needed as polars doesnt work well with forking on unix systems -import multiprocessing as mp -if mp.get_start_method(allow_none=True) != "spawn": - mp.set_start_method("spawn", force=True) +# Polars has issues with fork on Unix; enforce "spawn" early +import sys +import multiprocessing as mp +if sys.platform != "win32" and mp.get_start_method(allow_none=True) != "spawn": + mp.set_start_method("spawn", force=True)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/build-windows-executable-app.yaml(1 hunks)app.py(1 hunks)settings.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-openms
- GitHub Check: build-full-app
🔇 Additional comments (3)
app.py (1)
1-5: LGTM: enforce spawn before other imports.
This should prevent Polars fork issues by setting the start method early..github/workflows/build-windows-executable-app.yaml (1)
17-17: APP_NAME updated to 0.9.14 — matches settings.json.
Verified .github/workflows/build-windows-executable-app.yaml contains FLASHApp-0.9.14 and settings.json version is 0.9.14; no FLASHApp-0.9.13 occurrences found.settings.json (1)
4-4: Version bump looks good; please check for stale references to 0.9.13.
Keep settings.json, workflow, and any docs in sync.Run to find leftovers:
(hopefully)
Summary by CodeRabbit
Bug Fixes
Chores