tests: Added unit test for notes service

Author: OscarS05

api/src/modules/note/notes.controllers.js

@@ -4,15 +4,10 @@ const notesService = require('./notes.service');
 
 const getAllNotes = async (req, res, next) => {
   try {
-    const { title } = req.query;
+    const { query } = req;
     const userId = req.user.sub;
 
-    const filters = {
-      userId,
-      ...(title && { title }),
-    };
-
-    const note = await notesService.getAllNotes(filters);
+    const note = await notesService.getAllNotes({ ...query, userId });
 
     res.status(200).json({ note, sucess: true });
   } catch (error) {

api/src/modules/note/notes.service.js

@@ -1,47 +1,87 @@
 const Boom = require('@hapi/boom');
+const { Op } = require('sequelize');
 const { v4: uuidv4 } = require('uuid');
 
 const noteRepository = require('./notes.repository');
 
 const formatNotes = (note) => {
   return {
     id: note.id,
-    vaccine: note.title,
+    title: note.title,
     description: note.description || null,
     userId: note.user ? note.user.id : null,
     user: note.user ? note.user.name : null,
     createdAt: note.createdAt.toISOString().split('T')[0] || note.createdAt,
   };
 };
 
-const getAllNotes = async (filters) => {
+const buildFilters = (query) => {
+  const { title, userId } = query;
+
+  return {
+    ...(title && { title: { [Op.iLike]: `%${title}%` } }),
+    ...(userId && { userId }),
+  };
+};
+
+const getAllNotes = async (query) => {
+  if (!query || typeof query !== 'object') {
+    throw Boom.badRequest('query was not provided');
+  }
+
+  if (!query?.userId) {
+    throw Boom.badData('userId was not provided');
+  }
+
+  const filters = buildFilters(query);
+
   const notes = await noteRepository.findAllNotes(filters);
   if (!notes?.length === 0) return [];
+
   return notes.map((note) => formatNotes(note));
 };
 
 const getNote = async (userId, noteId) => {
+  if (!userId) throw Boom.notFound('userId was not provided');
+  if (!noteId) throw Boom.notFound('noteId was not provided');
+
   const note = await noteRepository.findOne(userId, noteId);
   if (!note?.id) throw Boom.notFound('Note does not exist');
+
   return formatNotes(note);
 };
 
 const createNote = async (noteData) => {
+  if (!noteData?.userId) {
+    throw Boom.badRequest('userId was not provided');
+  }
+  if (!noteData?.title && !noteData?.description) {
+    throw Boom.badRequest('noteData was not provided');
+  }
+
   const note = {
     id: uuidv4(),
     title: noteData.title,
-    description: noteData.description || null,
+    description: noteData?.description || null,
     userId: noteData.userId,
     createdAt: noteData.createdAt || new Date().toISOString().split('T')[0],
   };
 
   const newnote = await noteRepository.create(note);
-  if (!newnote?.id)
+  if (!newnote?.id) {
     throw Boom.badRequest('Something went wrong creating the note');
+  }
+
   return newnote;
 };
 
 const updateNote = async (userId, noteId, noteData) => {
+  if (!userId) throw Boom.badRequest('userId was not provided');
+  if (!noteId) throw Boom.badRequest('noteId was not provided');
+  if (!noteData?.title && !noteData?.description) {
+    throw Boom.badRequest('noteData was not provided');
+  }
+
   const note = await getNote(userId, noteId);
   if (!note?.id) throw Boom.notFound('Note does not exist');
 
@@ -54,17 +94,28 @@ const updateNote = async (userId, noteId, noteData) => {
     noteId,
     formattedNoteData,
   );
+
   if (updatedRows === 0) {
     throw Boom.badRequest('Something went wrong creating the note');
   }
+
   return updatedNote;
 };
 
 const deleteNote = async (userId, noteId) => {
+  if (!userId) throw Boom.badRequest('userId was not provided');
+  if (!noteId) throw Boom.badRequest('noteId was not provided');
+
   const note = await getNote(userId, noteId);
   if (!note?.id) throw Boom.conflict('note does not exists');
 
-  return noteRepository.destroy(noteId);
+  const affectedRows = await noteRepository.destroy(noteId);
+
+  if (affectedRows === 0) {
+    throw Boom.badRequest('Something went wrong deleting the note');
+  }
+
+  return affectedRows;
 };
 
 module.exports = {

api/src/modules/vaccination/vaccination.controllers.js

@@ -4,17 +4,12 @@ const vaccinationService = require('./vaccination.service');
 
 const getAllVaccination = async (req, res, next) => {
   try {
-    const { vaccine, animalId } = req.query;
+    const { query } = req;
     const userId = req.user.sub;
 
-    const filters = {
-      ...(vaccine && { vaccine }),
-      ...(animalId && { animalId }),
-    };
-
     const vaccinations = await vaccinationService.getAllVaccination(
       userId,
-      filters,
+      query,
     );
 
     res.status(200).json({ vaccinations, sucess: true });