Skip to content

API: Make the "Sensitive Files" GitHub Action more robust #3641

@palisadoes

Description

@palisadoes

Is your feature request related to a problem? Please describe.

  1. Our pull request GitHub action has a section that detects and fails when sensitive files are found to be submitted during PRs
    1. https://github.com/PalisadoesFoundation/talawa-api/blob/develop/.github/workflows/pull-request.yml
  2. If the required GitHub label is applied the test is skipped
  3. The test only works when a new commit is submitted, and not when the test is re-run
  4. The list of files is a string

Describe the solution you'd like

  1. Make the list of files in the GitHub action a list.
  2. Modify the test to work when both a new commit is submitted and also when the test is re-run
  3. Test this GitHub action in your own repository before submitting your PR

Additional context

  1. Test this GitHub action in your own repository before submitting your PR
  2. This has already been implemented in Talawa-Admin. Use the YAML from the PR for this issue and update the SENSITIVE_PATTERNS variable to match the needs of this repository.
    1. Admin: Make the "Sensitive Files" GitHub Action more robust talawa-admin#4292
    2. https://github.com/PalisadoesFoundation/talawa-admin/blob/develop/.github/workflows/pull-request.yml

Related Issues

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

Metadata

Metadata

Labels

ci/cdPull requests that update GitHub Actions codefeature requesttestTesting application

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions