-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
ci/cdPull requests that update GitHub Actions codePull requests that update GitHub Actions codefeature requesttestTesting applicationTesting application
Description
Is your feature request related to a problem? Please describe.
- Our pull request GitHub action has a section that detects and fails when sensitive files are found to be submitted during PRs
- If the required GitHub label is applied the test is skipped
- The test only works when a new commit is submitted, and not when the test is re-run
- The list of files is a string
Describe the solution you'd like
- Make the list of files in the GitHub action a list.
- Modify the test to work when both a new commit is submitted and also when the test is re-run
- Test this GitHub action in your own repository before submitting your PR
Additional context
- Test this GitHub action in your own repository before submitting your PR
- This has already been implemented in Talawa-Admin. Use the YAML from the PR for this issue and update the
SENSITIVE_PATTERNSvariable to match the needs of this repository.
Related Issues
- API: Make the "Sensitive Files" GitHub Action more robust #3641
- Mobile: Make the "Sensitive Files" GitHub Action more robust talawa#2952
- Plugin: Make the "Sensitive Files" GitHub Action more robust talawa-plugin#54
- Docs: Make the "Sensitive Files" GitHub Action more robust talawa-docs#1024
- SwitchMap: Make the "Sensitive Files" GitHub Action more robust switchmap-ng#355
- DevDocs: Make the "Sensitive Files" GitHub Action more robust developer-docs#76
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
Metadata
Metadata
Assignees
Labels
ci/cdPull requests that update GitHub Actions codePull requests that update GitHub Actions codefeature requesttestTesting applicationTesting application
Type
Projects
Status
Done