Skip to content

Conversation

@paul0403
Copy link
Member

@paul0403 paul0403 commented Dec 8, 2025

Context:
Nanobind updated an hour ago, included is an update on how they handle their tsl::robin-map dependency.
wjakob/nanobind#1212

Description of the Change:
Anti-pin against the broken nanobind version.

Benefits:
Wheels work.

@paul0403 paul0403 requested review from a team, josephleekl and mlxd December 8, 2025 16:07
@paul0403 paul0403 added reviewer:require-wheels Pull Requests will need wheel building job successful before being merged author:build-wheels Run the wheel building workflows on this Pull Request urgent Mark a pull request as high priority labels Dec 8, 2025
@paul0403
Copy link
Member Author

paul0403 commented Dec 8, 2025

No changelog needed for just build system

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@mlxd
Copy link
Member

mlxd commented Dec 8, 2025

No changelog needed for just build system

Technical/internal changes should still be tracked.

@dime10
Copy link
Contributor

dime10 commented Dec 8, 2025

No changelog needed for just build system

Technical/internal changes should still be tracked.

We don't track things that aren't part of the "released" materials in the release notes. Github and the git repository still serve as an extensive development log of course. Happy to discuss any adjustments :)

@dime10
Copy link
Contributor

dime10 commented Dec 8, 2025

Let's close this as the offending version has been yanked

@dime10 dime10 closed this Dec 8, 2025
@dime10 dime10 removed the urgent Mark a pull request as high priority label Dec 8, 2025
@paul0403 paul0403 deleted the paul0403/fix_wheels_20251208 branch December 8, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:build-wheels Run the wheel building workflows on this Pull Request reviewer:require-wheels Pull Requests will need wheel building job successful before being merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants