-
Notifications
You must be signed in to change notification settings - Fork 714
add pass_name to transforms #8539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8539 +/- ##
========================================
Coverage 99.42% 99.43%
========================================
Files 587 588 +1
Lines 62271 62639 +368
========================================
+ Hits 61915 62283 +368
Misses 356 356 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isaacdevlugt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this 😁! Made some comments on the docs :)
mudit2812
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'll let Isaac have the final say in the documentation-related stuff as there is already lots of ongoing discussion about that.
Co-authored-by: Mudit Pandey <[email protected]>
JerryChen97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Isaac De Vlugt <[email protected]>
Co-authored-by: Isaac De Vlugt <[email protected]>
Co-authored-by: Isaac De Vlugt <[email protected]>
isaacdevlugt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch for this! One more discussion to be resolved (https://github.com/PennyLaneAI/pennylane/pull/8539/files#r2578665674) but it looks great :)
Note that doctest will be failing till we update the corresponding catalyst PR. I decided to just leave it failing for now so I don't have to go back and fix it after the catlayst PR goes in.
Context:
Exploring how to better unify pennylane transforms and catalyst passes. Will have matching catalyst PR.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-103775]