Fix linter violations (#341)

Fixes the linter violations.

Signed-off-by: Rémy Greinhofer <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Author: rgreinho

lambdas/src/core/link_header.rs

@@ -59,7 +59,7 @@ impl<'a> RelationType<'a> {
     /// assert_eq!(RelationType::parse(r#" ; rel="prev""#), Ok(("", RelationType::new("prev"))));
     /// assert_eq!(RelationType::parse(r#" ; rel="alternate stylesheet""#), Ok(("", RelationType::new("alternate stylesheet"))));
     /// ```
-    pub fn parse(i: &str) -> IResult<&str, RelationType> {
+    pub fn parse(i: &str) -> IResult<&str, RelationType<'_>> {
         let (i, _) = space0(i)?;
         let (i, _) = tag(";")(i)?;
         let (i, _) = space0(i)?;
@@ -141,6 +141,12 @@ impl Display for Link<'_> {
     }
 }
 
+impl<'a> Default for Link<'a> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'a> Link<'a> {
     /// Recognizes a Link.
     ///
@@ -150,7 +156,7 @@ impl<'a> Link<'a> {
     ///
     /// let link = Link::parse(r#"link: <https://api.github.com/repositories/1300192/issues?page=2>; rel="prev""#).unwrap();
     /// ```
-    pub fn parse(i: &str) -> IResult<&str, Link> {
+    pub fn parse(i: &str) -> IResult<&str, Link<'_>> {
         let (i, _) = alt((tag("Link:"), tag("link:")))(i)?;
         let (i, _) = space1(i)?;
         let (i, links) = separated_list1(tag(", "), LinkValues::parse)(i)?;
@@ -291,7 +297,7 @@ impl<'a> LinkValues<'a> {
         }
     }
 
-    pub fn parse(i: &str) -> IResult<&str, LinkValues> {
+    pub fn parse(i: &str) -> IResult<&str, LinkValues<'_>> {
         let (i, uri) = LinkTarget::parse(i)?;
         let (i, link_params) = many1(LinkParam::parse)(i)?;
         let lv = LinkValues::try_from_link_params(uri, &link_params);
@@ -341,7 +347,7 @@ impl<'a> LinkParam<'a> {
         self.token
     }
 
-    pub fn parse(i: &str) -> IResult<&str, LinkParam> {
+    pub fn parse(i: &str) -> IResult<&str, LinkParam<'_>> {
         let (i, _) = space0(i)?;
         let (i, _) = tag(";")(i)?;
         let (i, _) = space0(i)?;

lambdas/src/core/resource/ratings/db.rs

@@ -59,76 +59,6 @@ pub(crate) struct Bna {
     pub(crate) track: Option<f64>,
 }
 
-#[derive(Debug, FromQueryResult, Deserialize, Serialize)]
-pub struct Summary {
-    id: Uuid,
-    city_id: Uuid,
-    score: f64,
-    version: String,
-}
-
-#[derive(Debug, FromQueryResult, Deserialize, Serialize)]
-pub struct Infrastructure {
-    low_stress_miles: Option<f64>,
-    high_stress_miles: Option<f64>,
-}
-
-#[derive(Debug, FromQueryResult, Deserialize, Serialize)]
-pub struct Recreation {
-    community_centers: Option<f64>,
-    parks: Option<f64>,
-    recreation_trails: Option<f64>,
-    recreation_score: Option<f64>,
-}
-
-#[derive(Debug, FromQueryResult, Deserialize, Serialize)]
-pub struct Opportunity {
-    employment: Option<f64>,
-    higher_education: Option<f64>,
-    k12_education: Option<f64>,
-    opportunity_score: Option<f64>,
-    technical_vocational_college: Option<f64>,
-}
-
-#[derive(Debug, FromQueryResult, Deserialize, Serialize)]
-pub struct CoreServices {
-    dentists: Option<f64>,
-    doctors: Option<f64>,
-    grocery: Option<f64>,
-    hospitals: Option<f64>,
-    pharmacies: Option<f64>,
-    coreservices_score: Option<f64>,
-    social_services: Option<f64>,
-}
-
-#[derive(Debug, FromQueryResult, Deserialize, Serialize)]
-pub struct People {
-    people: Option<f64>,
-}
-
-#[derive(Debug, FromQueryResult, Deserialize, Serialize)]
-pub struct Retail {
-    retail: Option<f64>,
-}
-
-#[derive(Debug, FromQueryResult, Deserialize, Serialize)]
-pub struct Transit {
-    transit: Option<f64>,
-}
-
-// #[derive(Debug)]
-// pub enum BNAComponentValue {
-//     All(Bna),
-//     Summary(Summary),
-//     Infrastructure(Summary, Option<Infrastructure>),
-//     Recreation(Summary, Option<Recreation>),
-//     Opportunity(Summary, Option<Opportunity>),
-//     CoreServices(Summary, Option<CoreServices>),
-//     People(Summary, Option<People>),
-//     Retail(Summary, Option<Retail>),
-//     Transit(Summary, Option<Transit>),
-// }
-
 pub async fn fetch_ratings_summaries(
     db: &DatabaseConnection,
     page: u64,

lambdas/src/core/resource/schema.rs

@@ -257,44 +257,3 @@ pub(crate) struct PaginationParams {
     #[param(minimum = 1, maximum = 65536, example = 5)]
     page: Option<u64>,
 }
-
-#[derive(ToSchema, Serialize, Deserialize)]
-pub(crate) enum BikeLaneType {
-    BufferedLane,
-    Lane,
-    Path,
-    Sharrow,
-    Track,
-}
-
-impl FromStr for BikeLaneType {
-    type Err = serde_plain::Error;
-
-    fn from_str(s: &str) -> Result<Self, Self::Err> {
-        serde_plain::from_str::<Self>(s)
-    }
-}
-
-impl From<String> for BikeLaneType {
-    fn from(value: String) -> Self {
-        BikeLaneType::from_str(value.as_str()).expect("cannot serialize value")
-    }
-}
-
-impl Display for BikeLaneType {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        let value = serde_plain::to_string(&self).expect("cannot serialize value");
-        write!(f, "{value}")
-    }
-}
-impl From<entity::wrappers::BikeLaneType> for BikeLaneType {
-    fn from(value: entity::wrappers::BikeLaneType) -> Self {
-        match value {
-            entity::wrappers::BikeLaneType::BufferedLane => BikeLaneType::BufferedLane,
-            entity::wrappers::BikeLaneType::Lane => BikeLaneType::Lane,
-            entity::wrappers::BikeLaneType::Path => BikeLaneType::Path,
-            entity::wrappers::BikeLaneType::Sharrow => BikeLaneType::Sharrow,
-            entity::wrappers::BikeLaneType::Track => BikeLaneType::Track,
-        }
-    }
-}