fix(orbility): time parsing

Author: stakach

drivers/orbility/parking_rest_api.cr

@@ -31,15 +31,25 @@ class Orbility::ParkingRestAPI < PlaceOS::Driver
   macro check(response, klass)
     %response = {{ response }}
     raise "error: #{%response.status}\n#{%response.body}" unless %response.success?
-    %klass = {{klass}}.from_json(%response.body)
+    %klass = begin
+      {{klass}}.from_json(%response.body)
+    rescue error
+      logger.error { "error parsing response: #{%response.body}" }
+      raise error
+    end
     raise "error: #{%klass.to_pretty_json}" unless %klass.success?
     %klass
   end
 
   macro basic_check(response)
     %response = {{ response }}
     raise "error: #{%response.status}\n#{%response.body}" unless %response.success?
-    %conf = Confirmation.from_json(%response.body)
+    %conf = begin
+      Confirmation.from_json(%response.body)
+    rescue error
+      logger.error { "error parsing response: #{%response.body}" }
+      raise error
+    end
     if !%conf.success?
       logger.info { "basic request failed with: #{%conf.to_pretty_json}" }
     end

drivers/orbility/parking_rest_api_models.cr

@@ -54,12 +54,20 @@ module Orbility
 
   module CreatedConverter
     FORMAT = "%Y-%m-%dT%H:%M:%S.%L"
-    FORMAT_ALT = "%Y-%m-%dT%H:%M:%S"
 
     def self.from_json(value : JSON::PullParser) : Time
+      str = value.read_string
+
+      # the milliseconds may not exist or are not padded
+      result = str.split('.', 2)
+      timemain = result[0]
+      if result.size == 1
+        split = "000"
+      else
+        split = result[1].ljust(3, '0')
+      end
+      str = "#{timemain}.#{split}"
       Time.parse(value.read_string, FORMAT, Time::Location::UTC)
-    rescue Time::Format::Error
-      Time.parse(value.read_string, FORMAT_ALT, Time::Location::UTC)
     end
 
     def self.to_json(value : Time, json : JSON::Builder) : Nil

drivers/orbility/parking_user_sync.cr

@@ -10,7 +10,7 @@ class Orbility::ParkingUserSync < PlaceOS::Driver
 
   descriptive_name "Orbility User Sync"
   generic_name :OrbilityUserSync
-  description %(Grabs users from active directory, looks up swipe card numbers from gallagher and syncs these to orbility)
+  description %(Grabs users from active directory, looks up swipe card numbers from gallagher and syncs these to orbility.)
 
   default_settings({
     # Azure user group we want to sync