-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Simplify core (the rest of the changes from the simplify branch)
#4029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
The `autoloader` plugin is not loaded automatically.
✅ Deploy Preview for dev-prismjs-com ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Something weird is happening here: IDK why the tests fail. Locally, all the tests pass. Hm, I need to investigate it. UPDATE: Fixed! Anyway, it's a giant leap forward, since there are a few minor changes left in the |
Oh, I know why this happens. Locally, I have applied the changes from #4018. Therefore, the updated API leverages the new, more declarative language definitions. I'll update the PR's description to reflect that. |
We use the `CustomEvent` class, which [became stable in `v20.13`](https://nodejs.org/api/events.html#class-customevent).
043734b to
b47255c
Compare
Found after running the `regex-coverage` npm script.
Found after running the `regex-coverage` npm script.
222f845 to
dd0af79
Compare
Depends on #4018.
Summary
Most of the code was authored by @LeaVerou.
bashandcss-selector(actually, we didn't have tests for it at all 🤷♂️)global.jsentry point to work with bare Prism (without theautoloaderplugin loaded automatically)We use the
CustomEventclass, which became stable inv20.13.Demo: https://codepen.io/dmitrysharabin/pen/qEbeEXv