Fix noise seed #5896
Merged
Fix noise seed #5896
+15
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids some need to recalculate noise when the alpha is changed.
cwisniew
approved these changes
Dec 2, 2025
github-project-automation
bot
moved this from Awaiting-Review
to To-Be-Merged
in MapTool 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #5895
Description of the Change
Changes
DrawableNoiseto create a newPerlinNoisewhen the seed is changed.Also, don't incorporate the alpha into the noise image, since that can be done by changing the alpha composite during rendering. This avoids recalcs when only the alpha is changed.
Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
/texturenoiseto use the supplied seed.This change is