Skip to content

Commit 5f9b5e0

Browse files
committed
Fix Julia heredoc escaping issues in install_rms.sh
Use quoted heredoc delimiters ('EOF' instead of EOF) to prevent bash from interpreting backslashes and variable substitutions within Julia code blocks. This fixes ParseError caused by escaped quotes being consumed by bash. Also changed to access shell variables via Julia's ENV dict for clarity. Seemed to be a problem only on the macos github runner. Hopefully this works cross platform.
1 parent 7317b3f commit 5f9b5e0

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

install_rms.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,11 @@ EOF
132132
# Install RMS
133133
if [ "$RMS_INSTALLER" = "standard" ] || [ "$RMS_INSTALLER" = "continuous" ]; then
134134
echo "Installing RMS from branch: $RMS_BRANCH"
135-
julia << EOF || echo "RMS standard install error - continuing anyway ¯\\_(ツ)_/¯"
135+
julia << 'EOF' || echo "RMS standard install error - continuing anyway ¯\\_(ツ)_/¯"
136136
using Pkg
137137
Pkg.activate(ENV["PYTHON_JULIAPKG_PROJECT"])
138-
Pkg.add(Pkg.PackageSpec(name="ReactionMechanismSimulator", url="https://github.com/ReactionMechanismGenerator/ReactionMechanismSimulator.jl.git", rev="$RMS_BRANCH"))
139-
println(read(joinpath(dirname(pathof(ReactionMechanismSimulator)), \"..\", \"Project.toml\"), String))
138+
Pkg.add(Pkg.PackageSpec(name="ReactionMechanismSimulator", url="https://github.com/ReactionMechanismGenerator/ReactionMechanismSimulator.jl.git", rev=ENV["RMS_BRANCH"]))
139+
println(read(joinpath(dirname(pathof(ReactionMechanismSimulator)), "..", "Project.toml"), String))
140140
Pkg.instantiate()
141141
try
142142
@info "Loading RMS"
@@ -150,11 +150,11 @@ if [ "$RMS_INSTALLER" = "standard" ] || [ "$RMS_INSTALLER" = "continuous" ]; the
150150
EOF
151151
elif [ "$RMS_INSTALLER" = "developer" ]; then
152152
echo "Installing RMS in developer mode from path: $RMS_PATH"
153-
julia << EOF || echo "RMS developer install error - continuing anyway ¯\\_(ツ)_/¯"
153+
julia << 'EOF' || echo "RMS developer install error - continuing anyway ¯\\_(ツ)_/¯"
154154
using Pkg
155155
println(ENV["PYTHON_JULIAPKG_PROJECT"])
156156
Pkg.activate(ENV["PYTHON_JULIAPKG_PROJECT"])
157-
Pkg.develop(path="$RMS_PATH")
157+
Pkg.develop(path=ENV["RMS_PATH"])
158158
Pkg.instantiate()
159159
try
160160
@info "Loading RMS"

0 commit comments

Comments
 (0)