review: review fixes

Author: EmogurovAnton

buildSrc/build.gradle.kts

@@ -11,9 +11,8 @@ tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> {
     compilerOptions.jvmTarget.set(JvmTarget.JVM_17)
 }
 
-java {
-    targetCompatibility = JavaVersion.VERSION_17
-    sourceCompatibility = JavaVersion.VERSION_17
+kotlin {
+    jvmToolchain(17)
 }
 
 dependencies {

buildSrc/src/main/kotlin/convention.debug.panel.plugin.gradle.kts

@@ -25,11 +25,6 @@ android {
             )
         }
     }
-
-    compileOptions {
-        sourceCompatibility = JavaVersion.VERSION_17
-        targetCompatibility = JavaVersion.VERSION_17
-    }
 }
 
 kotlin {
@@ -39,4 +34,4 @@ kotlin {
 
 dependencies {
     implementation(project(":panel-core"))
-}
+}

panel-core/build.gradle.kts

@@ -27,11 +27,6 @@ android {
         }
     }
 
-    compileOptions {
-        sourceCompatibility = JavaVersion.VERSION_17
-        targetCompatibility = JavaVersion.VERSION_17
-    }
-
     kotlin {
         jvmToolchain(17)
     }

panel-no-op/build.gradle.kts

@@ -26,11 +26,6 @@ android {
         }
     }
 
-    compileOptions {
-        sourceCompatibility = JavaVersion.VERSION_17
-        targetCompatibility = JavaVersion.VERSION_17
-    }
-
     kotlin {
         jvmToolchain(17)
     }
@@ -39,7 +34,7 @@ android {
 }
 
 dependencies {
-    implementation(kotlin("stdlib"))
+    implementation(stack.kotlin.stdlib)
     implementation(androidx.appcompat)
     implementation(stack.okhttp)
     implementation(stack.kotlinx.coroutines.android)

panel-no-op/src/main/kotlin/com/redmadrobot/debug/noop/plugin/aboutapp/AboutAppPlugin.kt

@@ -2,5 +2,5 @@ package com.redmadrobot.debug.plugin.aboutapp
 
 @Suppress("UnusedPrivateProperty")
 class AboutAppPlugin(
-    private val appInfoList: List<AboutAppInfo> = emptyList()
+    private val appInfoList: List<AboutAppInfo>
 )

sample/build.gradle.kts

@@ -12,11 +12,6 @@ android {
         targetSdk = Project.TARGET_SDK
     }
 
-    compileOptions {
-        sourceCompatibility = JavaVersion.VERSION_17
-        targetCompatibility = JavaVersion.VERSION_17
-    }
-
     buildTypes {
         getByName("release") {
             signingConfig = signingConfigs.getByName("debug")
@@ -29,7 +24,7 @@ kotlin {
 }
 
 dependencies {
-    implementation(kotlin("stdlib"))
+    implementation(stack.kotlin.stdlib)
     implementation(androidx.appcompat)
     implementation(androidx.activity.compose)
     implementation(androidx.lifecycle.runtime)

sample/src/main/kotlin/com/redmadrobot/debug_sample/MainActivity.kt

@@ -18,11 +18,8 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.unit.dp
 import androidx.lifecycle.lifecycleScope
 import com.redmadrobot.debug.core.DebugPanel
-import com.redmadrobot.debug.plugin.servers.ServerSelectedEvent
 import com.redmadrobot.debug_sample.network.ApiFactory
 import kotlinx.coroutines.Dispatchers
-import kotlinx.coroutines.flow.launchIn
-import kotlinx.coroutines.flow.onEach
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
 
@@ -31,7 +28,6 @@ class MainActivity : AppCompatActivity() {
         super.onCreate(savedInstanceState)
 
         setContent { MainActivityScreen() }
-        observeDebugPanelEvents()
     }
 
     @Composable
@@ -65,26 +61,6 @@ class MainActivity : AppCompatActivity() {
         }
     }
 
-    private fun observeDebugPanelEvents() {
-        DebugPanel.subscribeToEvents(this) { event ->
-            when (event) {
-                is ServerSelectedEvent -> {
-                    //Обработка выбора сервера
-                }
-            }
-        }
-
-        DebugPanel.observeEvents()
-            .onEach { event ->
-                when (event) {
-                    is ServerSelectedEvent -> {
-                        //Обработка выбора сервера
-                    }
-                }
-            }
-            .launchIn(lifecycleScope)
-    }
-
     private fun makeTestRequest() {
         lifecycleScope.launch {
             var requestedUrl: String? = null