Internal improvements

Read standard strings only once
Use translatable strings

Author: Rookiestyle

src/AWM.cs

@@ -112,17 +112,25 @@ internal void Disable()
 			catch { }
 		}
 
-		private void AddMenu(ref ToolStripMenuItem tsmiContainer, ref ToolStripMenuItem tsmiLastWindow, ref ToolStripComboBox tscbWindows)
-		{
-			tsmiContainer = new ToolStripMenuItem(KPRes.AutoType + ": ", m_imgDefaultIcon);
-			string s = "Add";
-			var f = KeePass.Program.Translation.Forms.FirstOrDefault(x => x.FullName == "KeePass.Forms.PwEntryForm");
-			if (f != null)
+		private static string _sAddText = string.Empty;
+		private static string GetTextForAdd()
+        {
+			if (string.IsNullOrEmpty(_sAddText))
 			{
-				var c = f.Controls.FirstOrDefault(x => x.Name == "m_btnAutoTypeAdd");
-				if (c != null) s = c.Text;
+				_sAddText = "Add";
+				var f = KeePass.Program.Translation.Forms.FirstOrDefault(x => x.FullName == "KeePass.Forms.PwEntryForm");
+				if (f != null)
+				{
+					var c = f.Controls.FirstOrDefault(x => x.Name == "m_btnAutoTypeAdd");
+					if (c != null) _sAddText = c.Text;
+				}
 			}
-			tsmiContainer.Text += s;
+			return _sAddText;
+		}
+
+		private void AddMenu(ref ToolStripMenuItem tsmiContainer, ref ToolStripMenuItem tsmiLastWindow, ref ToolStripComboBox tscbWindows)
+		{
+			tsmiContainer = new ToolStripMenuItem(KPRes.AutoType + ": " + GetTextForAdd(), m_imgDefaultIcon);
 			tsmiContainer.DropDown = new ToolStripDropDown();
 			tsmiContainer.DropDown.LayoutStyle = ToolStripLayoutStyle.Table;
 			var settings = tsmiContainer.DropDown.LayoutSettings as TableLayoutSettings;
@@ -151,11 +159,10 @@ private void AddMenu(ref ToolStripMenuItem tsmiContainer, ref ToolStripMenuItem
 
 		private void OnKeyDown(object sender, KeyEventArgs e)
 		{
-			if (e.KeyCode == Keys.Enter)
-			{
-				var t = (sender as ToolStripComboBox).GetCurrentParent() as ToolStripDropDown;
-				t.Items[2].PerformClick();
-			}
+			if (e.KeyCode != Keys.Enter) return;
+			
+			var t = (sender as ToolStripComboBox).GetCurrentParent() as ToolStripDropDown;
+			t.Items[2].PerformClick();
 		}
 
 		private void OnAddPreviousWindow(object sender, EventArgs e)
@@ -226,9 +233,7 @@ private AWMDuplicateHandling GetDuplicateHandling(string s)
 			else
 			{
 				string text = PluginTranslate.AWMCheckDuplicateInfo+"\n\n"+string.Format(PluginTranslate.AWMCheckDuplicateDetails,
-				DialogResult.Yes.ToString(),
-				DialogResult.No.ToString(),
-				DialogResult.Cancel.ToString());
+				KPRes.Yes, KPRes.No, KPRes.Cancel);
 				DialogResult r = MessageBox.Show(text, PluginTranslate.PluginName + ": " + m_tsmiCtxContainer.Text.Replace("&", string.Empty),
 					MessageBoxButtons.YesNoCancel);
 				if (r == DialogResult.Yes) return AWMDuplicateHandling.Edit;