Do not remove 'use v5.26' or higher from code before syntax check, and check for compliance with the minimal supported version

[bschmalhofer]

Currently Kernel/TidyAll/Plugin/OTOBO/Perl/SyntaxCheck.pm removes use statements from code before checking the syntax. This is because the required modules may not be available for the syntax check. use v5.24; is not removed because it is on a white list. This is important as for example use v5.24; introduces say as a builtin.

All is fine for the current state. But in future higher versions of Perl might be required and higher use v5.XX; might be in the code. The higher versions should also be on the white list.

[bschmalhofer]

The changes have been pushed to the internal repositories at Rother OSS. Closing this issue here only when the code has been updated here in GitHub as well.

[stefanhaerter]

Following a brief discussion with Sven, decision is to not allow additional version statements for rel-10_0, rel-10_1 and rel-11_0. The reason is that it should not be possible to add use statements above the minimum required version.

Instead, use v5.26 should be allowed in addition to use v5.24 in the CodePolicy master branch, which is intended to be used for rel-11_1.

[bschmalhofer]

Sure, I'll change that. Are there objections on adding those higher version to the list of discouraged modules,

CodePolicy/Kernel/TidyAll/Plugin/OTOBO/Perl/perlcriticrc

Line 64 in 33c913d

[Modules::ProhibitEvilModules]

?

[stefanhaerter]

Are there objections on adding those higher version to the list of discouraged modules,

Not from my side.

With permission from @svenoe, I just merged rel-11_0 into master and pushed. So, use v5.26 can now be allowed on the master and disallowed on the other branches.

[bschmalhofer]

Changed the scope of this issue. This is because prohibiting the requirement for higher versions is more important than the quirk in ./Kernel/TidyAll/Plugin/OTOBO/Perl/SyntaxCheck.pm.

TODO;

• adapt SyntaxCheck.pm to be based on a regex for those version pragmata, avoid the need to adapt the check in future
• discourage v5.26 or higher in rel-10_0, rel-10_1, rel-11_0
• discourage v5.28 or higher in master

[bschmalhofer]

Looks like Modules::ProhibitEvilModules can't be used as that policy correctly cringes at v5.26 in the modules attribute.

So, add the check in the venerable Kernel/TidyAll/Plugin/OTOBO/Perl/SyntaxCheck.pm