Remove unused compression plugin support

The compression plugin infrastructure (-c option) was added in 2003 but
no sippcomp.so plugin was ever distributed with SIPp. This was likely
intended for SigComp (RFC 3320, updated by RFC 4896) support that never
materialized.

If SigComp support is desired in the future, it should be implemented
properly as a built-in feature rather than through an undocumented
plugin interface.

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Assisted-by: Claude (Anthropic) <https://claude.ai>

Author: lemenkov

include/call.hpp

@@ -220,8 +220,6 @@ class call : virtual public task, virtual public listener, public virtual socket
     SIPpSocket *call_remote_socket;
     int            call_port;
 
-    void         * comp_state;
-
     int            deleted;
 
     bool           call_established; // == true when the call is established

include/comp.h

@@ -71,7 +71,6 @@
 #include "socket.hpp"
 #include "socketowner.hpp"
 #include "call.hpp"
-#include "comp.h"
 #include "variables.hpp"
 #include "stat.hpp"
 #include "actions.hpp"
@@ -199,7 +198,6 @@ MAYBE_EXTERN unsigned long      deadcall_wait           DEFVAL(DEFAULT_DEADCALL_
 MAYBE_EXTERN bool               pause_msg_ign           DEFVAL(0);
 MAYBE_EXTERN bool               auto_answer             DEFVAL(false);
 MAYBE_EXTERN int                multisocket             DEFVAL(0);
-MAYBE_EXTERN int                compression             DEFVAL(0);
 MAYBE_EXTERN int                peripsocket             DEFVAL(0);
 MAYBE_EXTERN int                peripfield              DEFVAL(0);
 MAYBE_EXTERN bool               bind_local              DEFVAL(false);

include/sipp.hpp

@@ -106,7 +106,6 @@ class SIPpSocket {
     int ss_fd = -1;             /* The underlying file descriptor for this socket. */
     int ss_port = 0;            /* The port used by this socket */
     int ss_bind_port = 0;       /* Optional local port used by this socket */
-    void *ss_comp_state = nullptr;    /* The compression state. */
 
     bool ss_changed_dest = false;   /* Has the destination changed from default. */
     struct sockaddr_storage ss_dest; /* Who we are talking to. */
@@ -163,11 +162,6 @@ bool reconnect_allowed();
 
 /********************** Network Interfaces ********************/
 
-int send_message(int s, void ** comp_state, char * msg);
-#if defined(USE_OPENSSL) || defined(USE_WOLFSSL)
-int send_message_tls(SSL *s, void ** comp_state, char * msg);
-#endif
-
 /* Socket Buffer Management. */
 #define NO_COPY 0
 #define DO_COPY 1

include/socket.hpp

@@ -886,7 +886,6 @@ void call::init(scenario * call_scenario, SIPpSocket *socket, struct sockaddr_st
     paused_until = 0;
 
     call_port = 0;
-    comp_state = nullptr;
 
     start_time = clock_tick;
     call_established=false ;
@@ -1147,10 +1146,6 @@ call::~call()
 {
     computeStat(CStat::E_ADD_CALL_DURATION, clock_tick - start_time);
 
-    if(comp_state) {
-        comp_free(&comp_state);
-    }
-
     if (call_remote_socket && (call_remote_socket != main_remote_socket)) {
         call_remote_socket->close();
     }
@@ -1431,9 +1426,6 @@ int call::send_raw(const char * msg, int index, int len)
         callDebug("%s message voluntary lost (while sending) (index %d, hash %lu).\n",
                   TRANSPORT_TO_STRING(transport), index, hash(msg));
 
-        if(comp_state) {
-            comp_free(&comp_state);
-        }
         call_scenario->messages[index] -> nb_lost++;
         return 0;
     }
@@ -4542,9 +4534,6 @@ bool call::process_incoming(const char* msg, const struct sockaddr_storage* src)
                           TRANSPORT_TO_STRING(transport));
                 callDebug("%s message (retrans) lost (recv) (hash %lu)\n", TRANSPORT_TO_STRING(transport), hash(msg));
 
-                if(comp_state) {
-                    comp_free(&comp_state);
-                }
                 call_scenario->messages[recv_retrans_recv_index] -> nb_lost++;
                 return true;
             }
@@ -5365,9 +5354,6 @@ bool call::process_incoming(const char* msg, const struct sockaddr_storage* src)
                   TRANSPORT_TO_STRING(transport));
         callDebug("%s message lost (recv) (hash %lu).\n",
                   TRANSPORT_TO_STRING(transport), hash(msg));
-        if(comp_state) {
-            comp_free(&comp_state);
-        }
         call_scenario->messages[search_index] -> nb_lost++;
         return true;
     }

src/call.cpp

@@ -374,12 +374,6 @@ void ScreenPrinter::draw_scenario_screen()
     }
     lines.push_back(buf);
 
-    if (compression) {
-        snprintf(buf, bufsiz, "  Comp resync: %d sent, %d recv", resynch_send,
-                 resynch_recv);
-        lines.push_back(buf);
-    }
-
     if (auto_answer) {
         snprintf(buf, 80, "  %llu requests auto-answered",
                  display_scenario->stats->GetStat(CStat::CPT_G_C_AutoAnswered));

src/comp.c

@@ -169,8 +169,6 @@ struct sipp_option options_table[] = {
         "- s1: SCTP with one socket,\n"
         "- sn: SCTP with one socket per call,\n"
 #endif
-        "- c1: u1 + compression (only if compression plugin loaded),\n"
-        "- cn: un + compression (only if compression plugin loaded).  This plugin is not provided with SIPp.\n"
         , SIPP_OPTION_TRANSPORT, nullptr, 1
     },
     {"i", "Set the local IP address for 'Contact:','Via:', and 'From:' headers. Default is primary host IP address.\n", SIPP_OPTION_IP, local_ip, 1},
@@ -347,7 +345,7 @@ struct sipp_option options_table[] = {
     {"", "Performance and watchdog options:", SIPP_HELP_TEXT_HEADER, nullptr, 0},
     {"timer_resol", "Set the timer resolution. Default unit is milliseconds.  This option has an impact on timers precision."
      "Small values allow more precise scheduling but impacts CPU usage."
-     "If the compression is on, the value is set to 50ms. The default value is 10ms.", SIPP_OPTION_TIME_MS, &timer_resolution, 1},
+     "The default value is 10ms.", SIPP_OPTION_TIME_MS, &timer_resolution, 1},
     {"max_recv_loops", "Set the maximum number of messages received read per cycle. Increase this value for high traffic level.  The default value is 1000.", SIPP_OPTION_INT, &max_recv_loops, 1},
     {"max_sched_loops", "Set the maximum number of calls run per event loop. Increase this value for high traffic level.  The default value is 1000.", SIPP_OPTION_INT, &max_sched_loops, 1},
 
@@ -1622,12 +1620,6 @@ int main(int argc, char *argv[])
                         exit(-1);
                     }
                     break;
-                case 'c':
-                    if (strlen(comp_error)) {
-                        ERROR("No " COMP_PLUGIN " plugin available: %s", comp_error);
-                    }
-                    transport = T_UDP;
-                    compression = 1;
                 }
                 switch(argv[argi][1]) {
                 case '1':
@@ -1953,13 +1945,6 @@ int main(int argc, char *argv[])
         global_ssrc_id = 0xCA110000;
     }
 
-    /* Load compression plugin if needed/available. */
-    if (compression) {
-        if (comp_load()) {
-            ERROR("Could not load " COMP_PLUGIN " plugin: %s", comp_error);
-        }
-    }
-
     if ((extendedTwinSippMode && !slave_masterSet) || (!extendedTwinSippMode && slave_masterSet)) {
         ERROR("-slave_cfg option must be used with -slave or -master option");
     }

src/screen.cpp

@@ -2141,19 +2141,6 @@ ssize_t SIPpSocket::write_primitive(const char* buffer, size_t len,
         break;
 
     case T_UDP:
-        if (compression) {
-            static char comp_msg[SIPP_MAX_MSG_SIZE];
-            strncpy(comp_msg, buffer, sizeof(comp_msg) - 1);
-            if (comp_compress(&ss_comp_state,
-                              comp_msg,
-                              (unsigned int *) &len) != COMP_OK) {
-                ERROR("Compression plugin error");
-            }
-            buffer = (char *)comp_msg;
-
-            TRACE_MSG("---\nCompressed message len: %zu\n", len);
-        }
-
         rc = sendto(ss_fd, buffer, len, 0, _RCAST(struct sockaddr*, dest),
                     socklen_from_addr(dest));
         break;