Skip to content

Commit 6025037

Browse files
committed
Updates for GDM test util
Small timing change with the check_home_screen wait. Drop unnecessary steps in login_idp. Add scauto_path to misc globals.
1 parent 9f28637 commit 6025037

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

sssd_test_framework/misc/globals.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@
22

33
test_venv = "/opt/test_venv"
44
test_venv_bin = f"{test_venv}/bin"
5+
scauto_path = f"{test_venv_bin}/scauto"

sssd_test_framework/utils/gdm.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99

1010
from pytest_mh import MultihostHost, MultihostUtility
1111

12+
from ..misc.globals import scauto_path
13+
1214
if TYPE_CHECKING:
1315
from ..roles.client import Client
1416

@@ -27,7 +29,7 @@ def __init__(self, host):
2729
super().__init__(host)
2830
self.init_completed = False
2931

30-
self.cmd = ["/opt/test_venv/bin/scauto", "gui", "--wait-time", "1", "--no-screenshot"]
32+
self.cmd = [scauto_path, "gui", "--wait-time", "1", "--no-screenshot"]
3133

3234
def teardown(self):
3335
if self.init_completed:
@@ -126,7 +128,7 @@ def check_home_screen(self) -> bool:
126128
if not self.init_completed:
127129
self.init()
128130

129-
cmd = ["/opt/test_venv/bin/scauto", "-v", "debug", "gui", "--wait-time", "5", "--no-screenshot"]
131+
cmd = [scauto_path, "-v", "debug", "gui", "--wait-time", "2", "--no-screenshot"]
130132
result = self.host.conn.exec([*cmd, "check-home-screen"], raise_on_error=False)
131133
return result.rc == 0
132134

@@ -163,8 +165,6 @@ def login_idp(self, client: Client, username: str, password: str) -> bool:
163165
client.journald.clear()
164166

165167
self.click_on("listed?")
166-
self.kb_send("tab")
167-
self.click_on("Username")
168168
self.kb_write(username)
169169
self.click_on("Log")
170170

0 commit comments

Comments
 (0)