Pass doubles by copy not reference (#135)

Author: EmilyBourne

include/GMGPolar/gmgpolar.h

@@ -249,7 +249,7 @@ class GMGPolar
     int number_of_iterations_;
     std::vector<double> residual_norms_;
     double mean_residual_reduction_factor_;
-    bool converged(const double& current_residual_norm, const double& first_residual_norm);
+    bool converged(double current_residual_norm, double first_residual_norm);
 
     /* ---------------------------------------------------- */
     /* Compute exact error if an exact solution is provided */

include/InputFunctions/BoundaryConditions/cartesianR2_Boundary_CircularGeometry.h

@@ -8,11 +8,11 @@ class CartesianR2_Boundary_CircularGeometry : public BoundaryConditions
 {
 public:
     CartesianR2_Boundary_CircularGeometry() = default;
-    explicit CartesianR2_Boundary_CircularGeometry(const double& Rmax);
+    explicit CartesianR2_Boundary_CircularGeometry(double Rmax);
     virtual ~CartesianR2_Boundary_CircularGeometry() = default;
 
-    double u_D(const double& r, const double& theta) const override;
-    double u_D_Interior(const double& r, const double& theta) const override;
+    double u_D(double r, double theta) const override;
+    double u_D_Interior(double r, double theta) const override;
 
 private:
     const double Rmax = 1.3;

include/InputFunctions/BoundaryConditions/cartesianR2_Boundary_CzarnyGeometry.h

@@ -8,13 +8,13 @@ class CartesianR2_Boundary_CzarnyGeometry : public BoundaryConditions
 {
 public:
     explicit CartesianR2_Boundary_CzarnyGeometry();
-    explicit CartesianR2_Boundary_CzarnyGeometry(const double& Rmax, const double& inverse_aspect_ratio_epsilon,
-                                                 const double& ellipticity_e);
+    explicit CartesianR2_Boundary_CzarnyGeometry(double Rmax, double inverse_aspect_ratio_epsilon,
+                                                 double ellipticity_e);
 
     virtual ~CartesianR2_Boundary_CzarnyGeometry() = default;
 
-    double u_D(const double& r, const double& theta) const override;
-    double u_D_Interior(const double& r, const double& theta) const override;
+    double u_D(double r, double theta) const override;
+    double u_D_Interior(double r, double theta) const override;
 
 private:
     const double Rmax                         = 1.3;

include/InputFunctions/BoundaryConditions/cartesianR2_Boundary_ShafranovGeometry.h

@@ -8,12 +8,11 @@ class CartesianR2_Boundary_ShafranovGeometry : public BoundaryConditions
 {
 public:
     CartesianR2_Boundary_ShafranovGeometry() = default;
-    explicit CartesianR2_Boundary_ShafranovGeometry(const double& Rmax, const double& elongation_kappa,
-                                                    const double& shift_delta);
+    explicit CartesianR2_Boundary_ShafranovGeometry(double Rmax, double elongation_kappa, double shift_delta);
     virtual ~CartesianR2_Boundary_ShafranovGeometry() = default;
 
-    double u_D(const double& r, const double& theta) const override;
-    double u_D_Interior(const double& r, const double& theta) const override;
+    double u_D(double r, double theta) const override;
+    double u_D_Interior(double r, double theta) const override;
 
 private:
     const double Rmax             = 1.3;

include/InputFunctions/BoundaryConditions/cartesianR6_Boundary_CircularGeometry.h

@@ -8,11 +8,11 @@ class CartesianR6_Boundary_CircularGeometry : public BoundaryConditions
 {
 public:
     CartesianR6_Boundary_CircularGeometry() = default;
-    explicit CartesianR6_Boundary_CircularGeometry(const double& Rmax);
+    explicit CartesianR6_Boundary_CircularGeometry(double Rmax);
     virtual ~CartesianR6_Boundary_CircularGeometry() = default;
 
-    double u_D(const double& r, const double& theta) const override;
-    double u_D_Interior(const double& r, const double& theta) const override;
+    double u_D(double r, double theta) const override;
+    double u_D_Interior(double r, double theta) const override;
 
 private:
     const double Rmax = 1.3;

include/InputFunctions/BoundaryConditions/cartesianR6_Boundary_CzarnyGeometry.h

@@ -8,13 +8,13 @@ class CartesianR6_Boundary_CzarnyGeometry : public BoundaryConditions
 {
 public:
     explicit CartesianR6_Boundary_CzarnyGeometry();
-    explicit CartesianR6_Boundary_CzarnyGeometry(const double& Rmax, const double& inverse_aspect_ratio_epsilon,
-                                                 const double& ellipticity_e);
+    explicit CartesianR6_Boundary_CzarnyGeometry(double Rmax, double inverse_aspect_ratio_epsilon,
+                                                 double ellipticity_e);
 
     virtual ~CartesianR6_Boundary_CzarnyGeometry() = default;
 
-    double u_D(const double& r, const double& theta) const override;
-    double u_D_Interior(const double& r, const double& theta) const override;
+    double u_D(double r, double theta) const override;
+    double u_D_Interior(double r, double theta) const override;
 
 private:
     const double Rmax                         = 1.3;

include/InputFunctions/BoundaryConditions/cartesianR6_Boundary_ShafranovGeometry.h

@@ -8,12 +8,11 @@ class CartesianR6_Boundary_ShafranovGeometry : public BoundaryConditions
 {
 public:
     CartesianR6_Boundary_ShafranovGeometry() = default;
-    explicit CartesianR6_Boundary_ShafranovGeometry(const double& Rmax, const double& elongation_kappa,
-                                                    const double& shift_delta);
+    explicit CartesianR6_Boundary_ShafranovGeometry(double Rmax, double elongation_kappa, double shift_delta);
     virtual ~CartesianR6_Boundary_ShafranovGeometry() = default;
 
-    double u_D(const double& r, const double& theta) const override;
-    double u_D_Interior(const double& r, const double& theta) const override;
+    double u_D(double r, double theta) const override;
+    double u_D_Interior(double r, double theta) const override;
 
 private:
     const double Rmax             = 1.3;

include/InputFunctions/BoundaryConditions/polarR6_Boundary_CircularGeometry.h

@@ -8,11 +8,11 @@ class PolarR6_Boundary_CircularGeometry : public BoundaryConditions
 {
 public:
     PolarR6_Boundary_CircularGeometry() = default;
-    explicit PolarR6_Boundary_CircularGeometry(const double& Rmax);
+    explicit PolarR6_Boundary_CircularGeometry(double Rmax);
     virtual ~PolarR6_Boundary_CircularGeometry() = default;
 
-    double u_D(const double& r, const double& theta) const override;
-    double u_D_Interior(const double& r, const double& theta) const override;
+    double u_D(double r, double theta) const override;
+    double u_D_Interior(double r, double theta) const override;
 
 private:
     const double Rmax = 1.3;

include/InputFunctions/BoundaryConditions/polarR6_Boundary_CulhamGeometry.h

@@ -8,11 +8,11 @@ class PolarR6_Boundary_CulhamGeometry : public BoundaryConditions
 {
 public:
     PolarR6_Boundary_CulhamGeometry() = default;
-    explicit PolarR6_Boundary_CulhamGeometry(const double& Rmax);
+    explicit PolarR6_Boundary_CulhamGeometry(double Rmax);
     virtual ~PolarR6_Boundary_CulhamGeometry() = default;
 
-    double u_D(const double& r, const double& theta) const override;
-    double u_D_Interior(const double& r, const double& theta) const override;
+    double u_D(double r, double theta) const override;
+    double u_D_Interior(double r, double theta) const override;
 
 private:
     const double Rmax = 1.3;

include/InputFunctions/BoundaryConditions/polarR6_Boundary_CzarnyGeometry.h

@@ -8,13 +8,12 @@ class PolarR6_Boundary_CzarnyGeometry : public BoundaryConditions
 {
 public:
     explicit PolarR6_Boundary_CzarnyGeometry();
-    explicit PolarR6_Boundary_CzarnyGeometry(const double& Rmax, const double& inverse_aspect_ratio_epsilon,
-                                             const double& ellipticity_e);
+    explicit PolarR6_Boundary_CzarnyGeometry(double Rmax, double inverse_aspect_ratio_epsilon, double ellipticity_e);
 
     virtual ~PolarR6_Boundary_CzarnyGeometry() = default;
 
-    double u_D(const double& r, const double& theta) const override;
-    double u_D_Interior(const double& r, const double& theta) const override;
+    double u_D(double r, double theta) const override;
+    double u_D_Interior(double r, double theta) const override;
 
 private:
     const double Rmax                         = 1.3;