Skip to content

Commit 1b7083b

Browse files
committed
fix: making validation safer
1 parent 3a0d5d7 commit 1b7083b

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

shared.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1085,7 +1085,6 @@ func HandleGetOrg(resp http.ResponseWriter, request *http.Request) {
10851085

10861086
org.SyncFeatures.EmailTrigger.Limit = 0
10871087

1088-
10891088
org.SyncFeatures.MultiTenant.Usage = int64(len(org.ChildOrgs) + 1)
10901089

10911090
if org.SyncUsage.MultiTenant.Counter != int64(len(org.ChildOrgs)+1) {
@@ -9277,7 +9276,6 @@ func HandleGetUsers(resp http.ResponseWriter, request *http.Request) {
92779276
// Overrides to ensure the user we are returning
92789277
// is accurate and not an org copy. Keeping roles from
92799278
// org, as that controls the actual roles.
9280-
foundUser = CleanCreds(foundUser)
92819279
newItem := *foundUser
92829280
newItem.Role = item.Role
92839281
newItem.Roles = []string{item.Role}
@@ -9411,6 +9409,12 @@ func HandleGetUsers(resp http.ResponseWriter, request *http.Request) {
94119409
}
94129410
}
94139411

9412+
// deduplicatedUsers = *CleanCreds(&deduplicatedUsers)
9413+
for userIndex, user := range deduplicatedUsers {
9414+
user = *CleanCreds(&user)
9415+
deduplicatedUsers[userIndex] = user
9416+
}
9417+
94149418
newjson, err := json.Marshal(deduplicatedUsers)
94159419
if err != nil {
94169420
log.Printf("[WARNING] Failed unmarshal in getusers: %s", err)

0 commit comments

Comments
 (0)