Changes on copilot review - use en-US culture for test in DateFieldTagHelperFixture.cs, extracting the culture selection logic into a separate variable for better readability in DateTagHelper.cs

Author: Krishanthaudayakumara

src/Sitecore.AspNetCore.SDK.RenderingEngine/TagHelpers/Fields/DateTagHelper.cs

@@ -67,7 +67,9 @@ public override void Process(TagHelperContext context, TagHelperOutput output)
 
         CultureInfo culture = !string.IsNullOrWhiteSpace(Culture) ? CultureInfo.CreateSpecificCulture(Culture) : CultureInfo.CurrentCulture;
 
-        string formattedDate = !string.IsNullOrWhiteSpace(DateFormat) ? field.Value.ToString(DateFormat, !string.IsNullOrWhiteSpace(Culture) ? culture : CultureInfo.InvariantCulture) : field.Value.ToString(culture);
+        CultureInfo formatCulture = !string.IsNullOrWhiteSpace(Culture) ? culture : CultureInfo.InvariantCulture;
+
+        string formattedDate = !string.IsNullOrWhiteSpace(DateFormat) ? field.Value.ToString(DateFormat, formatCulture) : field.Value.ToString(culture);
 
         HtmlString html = outputEditableMarkup ? new HtmlString(field.EditableMarkup) : new HtmlString(formattedDate);
 

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/TagHelpers/DateFieldTagHelperFixture.cs

@@ -41,7 +41,7 @@ public DateFieldTagHelperFixture()
                 app.UseRouting();
                 app.UseRequestLocalization(options =>
                 {
-                    var culture = new CultureInfo("da-DK");
+                    var culture = new CultureInfo("en-US");
                     options.DefaultRequestCulture = new RequestCulture(culture);
                     options.SupportedCultures = [culture];
                     options.SupportedUICultures = [culture];
@@ -103,7 +103,7 @@ public async Task DateTagHelper_GeneratesProperDate()
         // Assert
         sectionNode.ChildNodes[1].InnerHtml.Should().Be("05/04/2012");
         sectionNode.ChildNodes[3].InnerHtml.Should().Be("05/04/2012 00:00:00");
-        sectionNode.ChildNodes[5].InnerHtml.Should().Be(TestConstants.DateTimeValue.ToString(new CultureInfo("da-DK")));
+        sectionNode.ChildNodes[5].InnerHtml.Should().Be(TestConstants.DateTimeValue.ToString(new CultureInfo("en-US")));
         sectionNode.ChildNodes[9].InnerHtml.Should().Contain("04.05.2012");
     }